Skip to content

Enable 4.5.1 in stable channel(s) #326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Jul 15, 2020
Merged

Enable 4.5.1 in stable channel(s) #326

openshift-merge-robot merged 1 commit into from
Jul 15, 2020

Conversation

@openshift-bot
Copy link
Contributor

@openshift-bot openshift-bot commented Jul 11, 2020

Please merge within 48 hours of https://errata.devel.redhat.com/advisory/51809 shipping live OR a Cincinnati-first release.

This should provide adequate soak time for fast channel PR #325

@openshift-bot openshift-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 11, 2020
@sdodson
Copy link
Member

sdodson commented Jul 13, 2020

This will be held for a minimum of a week potentially longer while we evaluate telemetry data that comes in via fast channel upgrades.

@sdodson
Copy link
Member

sdodson commented Jul 14, 2020

/lgtm
/hold cancel
This is going into stable-4.5, however upgrades to this version are blocked via #328 please see that PR for more information.

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 14, 2020
@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 14, 2020
@openshift-bot
Copy link
Contributor Author

openshift-bot commented Jul 14, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

8 similar comments
@openshift-bot
Copy link
Contributor Author

openshift-bot commented Jul 14, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor Author

openshift-bot commented Jul 14, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor Author

openshift-bot commented Jul 14, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor Author

openshift-bot commented Jul 14, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor Author

openshift-bot commented Jul 14, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor Author

openshift-bot commented Jul 14, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor Author

openshift-bot commented Jul 14, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor Author

openshift-bot commented Jul 14, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@sdodson
Copy link
Member

sdodson commented Jul 14, 2020

/lgtm cancel

@sdodson
Copy link
Member

sdodson commented Jul 14, 2020 

 yaml.parser.ParserError: while parsing a block mapping
  in "./channels/stable-4.5.yaml", line 1, column 1
expected <block end>, but found '-'
  in "./channels/stable-4.5.yaml", line 4, column 1

@openshift-ci-robot openshift-ci-robot removed lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 14, 2020
@sdodson
Copy link
Member

sdodson commented Jul 14, 2020

Fixed versions: []
Since I made changes here @LalatenduMohanty PTAL, don't want to lgtm my own changes

@sdodson
Copy link
Member

sdodson commented Jul 15, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 15, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 15, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-bot, sdodson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 15, 2020
@openshift-bot
Copy link
Contributor Author

openshift-bot commented Jul 15, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 1488f83 into master Jul 15, 2020
@LalatenduMohanty
Copy link
Member

LalatenduMohanty commented Jul 16, 2020

@sdodson Sorry missed this email alert from github, feel free to ping on slack if you are waiting on me.

@sdodson sdodson deleted the pr-stable-4.5.1 branch October 12, 2020 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@steveej steveej Awaiting requested review from steveej

@wking wking Awaiting requested review from wking

Assignees

@sdodson sdodson

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@openshift-bot @sdodson @openshift-ci-robot @LalatenduMohanty @openshift-merge-robot