-
Notifications
You must be signed in to change notification settings - Fork 65
candidate-4.3: add 4.3.1 #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/approve |
|
Do we also want to add the 4.2 update source? Looks like that's 4.2.18: $ oc adm release info quay.io/openshift-release-dev/ocp-release:4.3.1-x86_64 | grep Upgrades
Upgrades: 4.2.18, 4.3.0-rc.0, 4.3.0-rc.3, 4.3.0I'm also fine if we want to punt putting 4.2.18 into candidate-4.3 to a separate PR. |
I was confused by the channel chain we're using. I'm fine with adding 4.2 builds in |
|
Looking through our CI updates, everything looks good except for:
|
|
Azure failure was probably due to slow disks. Tracked in rhbz#1798785. That's neither new nor update-specific, so my only remaining concerns with this channel promotion are:
Once we get the story around 4.2.18's existence straightened out, the update folks are fine with this. |
|
All three replacement 4.2.18 -> 4.3.1 Azure jobs passed, so that's a good sign too. |
|
going to retry 4.2.18 |
OTA wont be merging any PRs as it is up to the release admins. But OTA would provide info with respect to, if the edge looks stable enough by looking in to telemetry dash boards and CI results. |
…consider 4.2.18 is baked into 4.3.1 as a recommended update source, but we don't have a 4.2.18 release yet. Block until we have a release, to avoid accidentally adding 4.2.18 -> 4.3.1 to channels if 4.2.18 ends up being a dud.
I've pushed 060341c -> 9c77b39 to your branch for this PR blocking 4.2.18->4.3.1 until we have a 4.2.18 to consider. Generated with: $ git remote add sosiouxme ssh://github.com/sosiouxme/cincinnati-graph-data.git
$ git fetch sosiouxme
$ git checkout sosiouxme/patch-3
$ emacs blocked-edges/4.3.1.yaml # manually fill this in
$ git add blocked-edges/4.3.1.yaml
$ git commit -v
$ git push sosiouxme HEAD:patch-3 |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eparis, sosiouxme The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The release has been in the candidate analogs since 6ed3a35 (candidate-4.2: add 4.2.18, 2020-02-12, #49), which is plenty of cook time. Also, now that we have a 4.2.18, we can drop the blocked edge from 9c77b39 (blocked-edges/4.3.1: Block 4.2.18 -> 4.3.1 until we have a 4.2.18 to consider, 2020-02-06, #43). Would have been nice if that had happened in 6ed3a35, but better late than never ;).
No description provided.