Skip to content

Conversation

@wking
Copy link
Member

@wking wking commented Feb 6, 2020

792cc4c (#40) pulled the block to allow this edge, but to get an edge in a given channel, both the source and target release need to be in that channel.

See also #44, which goes into more detail on 4.2->4.3 failure modes, some of which still occur on 4.2.16->4.3.0.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 6, 2020
792cc4c (Enable the 4.2.16 to 4.3.0 upgrade, 2020-02-03, #40)
pulled the block to allow this edge, but to get an edge in a given
channel, both the source and target release need to be in that
channel.  This was added to fast-4.3 in 792cc4c and later
restricted to amd64 in 9a25271 (Do not add 4.2 s390 release to 4.3
channels, 2020-02-03, #41), but we'd skipped over candidate-4.3.
@wking wking force-pushed the 4.2.16-into-candidate-4.3 branch from 28e3319 to 0a03965 Compare February 6, 2020 19:10
@wking wking changed the title channels/candidate-4.3: Promote 4.2.16 channels/candidate-4.3: Promote 4.2.16+amd64 Feb 6, 2020
@eparis
Copy link
Member

eparis commented Feb 6, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 6, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eparis, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 6, 2020
@openshift-merge-robot openshift-merge-robot merged commit 74ffd04 into openshift:master Feb 6, 2020
@wking wking deleted the 4.2.16-into-candidate-4.3 branch February 6, 2020 20:48
@wking wking mentioned this pull request Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants