candidate-4.2: add 4.2.18 #49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/XS
eparis
reviewed
Feb 12, 2020
channels/candidate-4.3.yaml
Outdated
| versions: | ||
| # until s390 is released on 4.3 we may not want to include it in 4.3 channels | ||
| - 4.2.16+amd64 | ||
| - 4.2.18 |
Member
Author
There was a problem hiding this comment.
oh yes, sorry ... added!
Member
|
/approve |
openshift-ci-robot
added
do-not-merge/hold
vrutkovs
approved these changes
Feb 12, 2020
vrutkovs
left a comment
vrutkovs
left a comment
There was a problem hiding this comment.
/lgtm
keeping the hold for another review
Member
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eparis, LalatenduMohanty, thiagoalessio, vrutkovs The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
wking
referenced
this pull request
in wking/cincinnati-graph-data
Feb 20, 2020
The release has been in the candidate analogs since 6ed3a35 (candidate-4.2: add 4.2.18, 2020-02-12, #49), which is plenty of cook time. Also, now that we have a 4.2.18, we can drop the blocked edge from 9c77b39 (blocked-edges/4.3.1: Block 4.2.18 -> 4.3.1 until we have a 4.2.18 to consider, 2020-02-06, #43). Would have been nice if that had happened in 6ed3a35, but better late than never ;).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.