*: Remove executable bit from non-executable files #84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
wking
force-pushed
the
fix-executable-bit
branch
from
fcae51f to
cbfe4e1
Compare
Contributor
|
/lgtm |
Member
Author
|
/hold Let #85 go first, then I'll rebase this. |
openshift-ci-robot
added
the
do-not-merge/hold
Generated with:
$ find . -name '*.go' -execdir chmod 644 {} \+
$ find . -name '*.yaml' -execdir chmod 644 {} \+
Tracking one of the files:
$ git log -p --follow origin/master api/v1/groupversion_info.go | grep '^commit\|new.*mode'
...
commit d9f361a
new file mode 100755
So that was born executable in d9f361a (Migrate operator from
v0.18.2 to v0.19.3, 2020-09-30, openshift#65).
Three more buggy bits are from that commit:
$ git show d9f361a | grep -B2 'new mode'
diff --git a/pkg/apis/cincinnati/v1beta1/cincinnati_types.go b/api/v1beta1/cincinnati_types.go
old mode 100644
new mode 100755
--
diff --git a/pkg/apis/cincinnati/v1beta1/zz_generated.deepcopy.go b/api/v1beta1/zz_generated.deepcopy.go
old mode 100644
new mode 100755
--
diff --git a/pkg/controller/cincinnati/cincinnati_controller.go b/controllers/cincinnati_controller.go
old mode 100644
new mode 100755
The last three are from 36a102f (Migrate operator from v0.16.0 to
v0.18.2, 2020-09-17, openshift#67):
$ git show 36a102f | grep -B2 'new mode'
diff --git a/deploy/olm-catalog/cincinnati-operator/0.0.1/cincinnati-operator.v0.0.1.clusterserviceversion.yaml b/deploy/olm-catalog/cincinnati-operator/0.0.1/cincinnati-operator.v0.0.1.clusterserviceversion.yaml
old mode 100644
new mode 100755
diff --git a/deploy/olm-catalog/cincinnati-operator/0.0.1/cincinnati.openshift.io_cincinnatis_crd.yaml b/deploy/olm-catalog/cincinnati-operator/0.0.1/cincinnati.openshift.io_cincinnatis_crd.yaml
old mode 100644
new mode 100755
diff --git a/deploy/olm-catalog/cincinnati-operator/cincinnati-operator.package.yaml b/deploy/olm-catalog/cincinnati-operator/cincinnati-operator.package.yaml
old mode 100644
new mode 100755
wking
force-pushed
the
fix-executable-bit
branch
from
cbfe4e1 to
7d3faea
Compare
Member
Author
|
#85 landed. /hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
Contributor
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generated with:
These snuck in in d9f361a (#65) and 36a102f (#67).