Skip to content

Conversation

@steveej
Copy link
Contributor

@steveej steveej commented Jan 28, 2019

This aids in the the process of introducing consistency about the image term in
the automatic upgrades context.

Relates to openshift/api#175.

/cc @smarterclayton

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 28, 2019
@steveej
Copy link
Contributor Author

steveej commented Jan 28, 2019

Need to self-review this tomorrow.

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 28, 2019
@smarterclayton
Copy link
Contributor

lgtm at a high level

Copy link
Contributor Author

@steveej steveej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a few capitalization bugs

This aids in the the process of introducing consistency about the image term in
the automatic upgrades context.
@steveej steveej force-pushed the rename-playload-to-image branch from c69ce5e to 5d226da Compare January 28, 2019 20:44
@steveej
Copy link
Contributor Author

steveej commented Jan 28, 2019

@smarterclayton I looked over this again and found a few capitalization bugs, the semantics sound OK to me. PTAL (your /lgtm was missing a / to be effective

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 28, 2019
@smarterclayton
Copy link
Contributor

/lgtm

Was intentional, figured it needed a bit more of a look.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 29, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: smarterclayton, steveeJ

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [smarterclayton,steveeJ]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 6f46bf5 into openshift:master Jan 29, 2019
@steveej steveej deleted the rename-playload-to-image branch January 29, 2019 08:26
@crawford
Copy link
Contributor

I know I'm showing up late, but I don't like this change. Are all consumers of Cincinnati going to use images to provide updates? I used the generic term in order to remain flexible to other use-cases.

@lucab
Copy link
Contributor

lucab commented Jan 30, 2019

@crawford indeed, when sitting on top of rpm-ostree this field would carry a refs-id or a commit-id or a URL. I find the original term more appropriate too.

However openshift/cluster-version-operator#98 preemptively changed the protocol on client side, and somehow the two pieces have to be consistent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants