-
Notifications
You must be signed in to change notification settings - Fork 60
*: rename payload -> image #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: rename payload -> image #49
Conversation
|
Need to self-review this tomorrow. /hold |
|
lgtm at a high level |
steveej
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found a few capitalization bugs
This aids in the the process of introducing consistency about the image term in the automatic upgrades context.
c69ce5e to
5d226da
Compare
|
@smarterclayton I looked over this again and found a few capitalization bugs, the semantics sound OK to me. PTAL (your /hold cancel |
|
/lgtm Was intentional, figured it needed a bit more of a look. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: smarterclayton, steveeJ The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
I know I'm showing up late, but I don't like this change. Are all consumers of Cincinnati going to use images to provide updates? I used the generic term in order to remain flexible to other use-cases. |
|
@crawford indeed, when sitting on top of rpm-ostree this field would carry a refs-id or a commit-id or a URL. I find the original term more appropriate too. However openshift/cluster-version-operator#98 preemptively changed the protocol on client side, and somehow the two pieces have to be consistent. |
This aids in the the process of introducing consistency about the image term in
the automatic upgrades context.
Relates to openshift/api#175.
/cc @smarterclayton