pkg/controllers: Use library-go's IngressURI helper #358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the helper from [1] to centralize some route handling and error message generation. Generated with: $ emacs pkg/... test/library/waits.go # everything in the diff $ go get github.com/openshift/library-go@f360b9835cc8815eccc26cb52dafe05d3cbb3e93 go: github.com/openshift/library-go f360b9835cc8815eccc26cb52dafe05d3cbb3e93 => v0.0.0-20201006230840-f360b9835cc8 $ go mod tidy $ go mod vendor $ git add -A go.* vendor using: $ go version go version go1.15.2 linux/amd64 [1]: openshift/library-go#911
wking
force-pushed
the
library-go-route-ingress-uri
branch
from
c5a4fed to
ef28bf0
Compare
Member
Author
|
/assign @sttts |
Contributor
|
/retest |
Contributor
|
/approve |
openshift-ci-robot
added
the
approved
Contributor
|
/lgtm nice refactoring @wking |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mfojtik, sttts, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the helper from openshift/library-go#911 to centralize some route handling and error message generation.
Generated with:
using: