Skip to content

Bug 1707877: Use internal url only for internal load balancer #464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
May 9, 2019
Merged

Bug 1707877: Use internal url only for internal load balancer #464

openshift-merge-robot merged 1 commit into from
May 9, 2019

Conversation

@damemi
Copy link
Contributor

@damemi damemi commented May 7, 2019

No description provided.

@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label May 7, 2019
@damemi damemi force-pushed the use-internal-url branch from 73f8132 to f28a774 Compare May 7, 2019 13:27
@damemi damemi mentioned this pull request May 7, 2019
Merged
@openshift openshift deleted a comment from abhinavdahiya May 7, 2019
@damemi damemi force-pushed the use-internal-url branch from f28a774 to f31c4d4 Compare May 7, 2019 14:32
@deads2k
Copy link
Contributor

deads2k commented May 7, 2019

relies on the one after openshift/installer#1718

/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 7, 2019
@abhinavdahiya
Copy link
Contributor

abhinavdahiya commented May 8, 2019

relies on the one after openshift/installer#1718

/lgtm

openshift/installer#1727 is the installer PR that moves to adding the public URL.

@wking
Copy link
Member

wking commented May 8, 2019 •
edited
Loading

/retest

openshift/installer#1718 has landed [edit: ah, looks like we're waiting on openshift/installer#1727, oh well]

@damemi damemi force-pushed the use-internal-url branch from f31c4d4 to c139dff Compare May 8, 2019 16:47
@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 8, 2019
@damemi damemi changed the title Use internal url for internal load balancer Use internal url only for internal load balancer May 8, 2019
@deads2k
Copy link
Contributor

deads2k commented May 8, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 8, 2019
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 8, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damemi, deads2k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@damemi
Copy link
Contributor Author

damemi commented May 8, 2019

/retest

1 similar comment
@eparis
Copy link
Member

eparis commented May 8, 2019

/retest

@eparis eparis changed the title Use internal url only for internal load balancer Bug 1707877: Use internal url only for internal load balancer May 8, 2019
@damemi
Copy link
Contributor Author

damemi commented May 8, 2019

/retest

1 similar comment
@eparis
Copy link
Member

eparis commented May 8, 2019

/retest

@deads2k
Copy link
Contributor

deads2k commented May 8, 2019

Guys, it needs openshift/installer#1727

@deads2k
Copy link
Contributor

deads2k commented May 8, 2019

Until openshift/installer#1727 merged the data in the cluster is wrong

@abhinavdahiya
Copy link
Contributor

abhinavdahiya commented May 8, 2019

/test e2e-aws

@abhinavdahiya
Copy link
Contributor

abhinavdahiya commented May 8, 2019

/test e2e-aws-operator

@wking
Copy link
Member

wking commented May 8, 2019

e2e-aws:

Installing from release registry.svc.ci.openshift.org/ci-op-tirqdfp4/release@sha256:4182c3386a92e18a53825b9da384128e729435214495a5b26a6b1657779f35d5
level=fatal msg="failed to fetch Terraform Variables: failed to fetch dependency of \"Terraform Variables\": failed to fetch dependency of \"Bootstrap Ignition Config\": failed to fetch dependency of \"Common Manifests\": failed to generate asset \"DNS Config\": getting public zone for \"origin-ci-int-aws.dev.rhcloud.com\": listing hosted zones: Throttling: Rate exceeded\n\tstatus code: 400, request id: 33e3ae82-71d6-11e9-adb1-e5c7a3ec66ff"

/test e2e-aws

@wking
Copy link
Member

wking commented May 8, 2019

Dunno why my /test didn't stick. Maybe this will:

/retest

@abhinavdahiya
Copy link
Contributor

abhinavdahiya commented May 8, 2019

/retest

@deads2k
Copy link
Contributor

deads2k commented May 8, 2019

Dunno why my /test didn't stick. Maybe this will:

/retest

github has had trouble with time today. People have been writing to us from the future and the bots go a little nuts

@wking
Copy link
Member

wking commented May 8, 2019 

2019/05/08 23:09:05 Pod e2e-aws succeeded after 1h0m50s

https://storage.googleapis.com/origin-ci-test/pr-logs/pull/openshift_cluster-kube-apiserver-operator/464/pull-ci-openshift-cluster-kube-apiserver-operator-master-e2e-aws/2213/build-log.txt

So any time now, Prow will notice and land this :)

@wking
Copy link
Member

wking commented May 8, 2019

Queued for retest <- noooo! https://prow.svc.ci.openshift.org/pr?query=is%3Apr+repo%3Aopenshift%2Fcluster-kube-apiserver-operator+author%3Adamemi+head%3Ause-internal-url

@wking
Copy link
Member

wking commented May 8, 2019

Wait, #465 looks related? Did we need that too for the beta blocker?

@wking
Copy link
Member

wking commented May 8, 2019

No, #465 merged ages ago. What are you doing, Tide? Can we just green-button this?

@deads2k
Copy link
Contributor

deads2k commented May 8, 2019

No, #465 merged ages ago. What are you doing, Tide? Can we just green-button this?

Is there some driver forcing that? I'd rather not. At this stage, with this risk profile, dependent on a recently merged change in another repo, I'd like to be sure of the green. There's nothing else in queue for this repo, I'm inclined to wait. until I see mostly green status.

@openshift-merge-robot openshift-merge-robot merged commit de5c06a into openshift:master May 9, 2019
@damemi damemi deleted the use-internal-url branch May 9, 2019 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abhinavdahiya abhinavdahiya Awaiting requested review from abhinavdahiya

@mfojtik mfojtik Awaiting requested review from mfojtik

Assignees

@deads2k deads2k

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@damemi @deads2k @abhinavdahiya @wking @openshift-ci-robot @eparis @openshift-merge-robot