Skip to content

Bug 1946479: manifests: use manual service account mounts #531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 3 commits into from
Jun 9, 2021
Merged

Bug 1946479: manifests: use manual service account mounts #531

openshift-merge-robot merged 3 commits into from
Jun 9, 2021

Conversation

@s-urbaniak
Copy link
Contributor

@s-urbaniak s-urbaniak commented Jun 8, 2021

/cc @stlaz

@openshift-ci openshift-ci bot requested a review from stlaz June 8, 2021 12:45
@s-urbaniak
Copy link
Contributor Author

s-urbaniak commented Jun 8, 2021

/hold
this is up for discussion

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 8, 2021
@s-urbaniak
Copy link
Contributor Author

s-urbaniak commented Jun 8, 2021

xref openshift/kubernetes#714

@s-urbaniak
manifests: use manual SA mounts
a876a7a 
Currently, any changes in serviceaccount admission
can cause a failed kube-controller-manager-operator deployment.

This fixes it by manually specyfing the serviceaccount mount.
@s-urbaniak s-urbaniak changed the title manifests,operator: use manual service account mounts manifests: use manual service account mounts Jun 8, 2021
@stlaz
Copy link
Contributor

stlaz commented Jun 8, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 8, 2021
@stlaz
Copy link
Contributor

stlaz commented Jun 8, 2021

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 8, 2021
@s-urbaniak
Copy link
Contributor Author

s-urbaniak commented Jun 8, 2021

/hold

@openshift-ci openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed lgtm Indicates that a PR is ready to be merged. labels Jun 8, 2021
@s-urbaniak
Copy link
Contributor Author

s-urbaniak commented Jun 8, 2021

/hold cancel
fixed the signature changes in library-go

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 8, 2021
@s-urbaniak s-urbaniak force-pushed the manual-sa-mount branch 2 times, most recently from 88c40be to 23fb923 Compare June 8, 2021 15:16
@stlaz
Copy link
Contributor

stlaz commented Jun 8, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 8, 2021
@s-urbaniak s-urbaniak changed the title manifests: use manual service account mounts Bug 1946479: manifests: use manual service account mounts Jun 8, 2021
@openshift-ci openshift-ci bot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Jun 8, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 8, 2021

@s-urbaniak: This pull request references Bugzilla bug 1946479, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @wangke19

Details

In response to this:

Bug 1946479: manifests: use manual service account mounts

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@s-urbaniak
Copy link
Contributor Author

s-urbaniak commented Jun 8, 2021

/bugzilla refresh

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jun 8, 2021
@openshift-ci openshift-ci bot requested a review from wangke19 June 8, 2021 15:30
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 8, 2021

@s-urbaniak: This pull request references Bugzilla bug 1946479, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @wangke19

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

soltysh
soltysh approved these changes Jun 8, 2021
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 9, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 9, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 9, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 9, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@s-urbaniak
Copy link
Contributor Author

s-urbaniak commented Jun 9, 2021

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 9, 2021
@s-urbaniak
Copy link
Contributor Author

s-urbaniak commented Jun 9, 2021

e2e failures are related, investigating.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 9, 2021
@stlaz
Copy link
Contributor

stlaz commented Jun 9, 2021

/lgtm

@stlaz
Copy link
Contributor

stlaz commented Jun 9, 2021

/hold cancel

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jun 9, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 9, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: s-urbaniak, soltysh, stlaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@s-urbaniak
Copy link
Contributor Author

s-urbaniak commented Jun 9, 2021

/retest

1 similar comment
@s-urbaniak
Copy link
Contributor Author

s-urbaniak commented Jun 9, 2021

/retest

@stlaz
Copy link
Contributor

stlaz commented Jun 9, 2021

/test e2e-upgrade

@s-urbaniak
Copy link
Contributor Author

s-urbaniak commented Jun 9, 2021

/test e2e-aws

@openshift-merge-robot openshift-merge-robot merged commit d194220 into openshift:master Jun 9, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 9, 2021

@s-urbaniak: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with /bugzilla refresh.

Bugzilla bug 1946479 has not been moved to the MODIFIED state.

Details

In response to this:

Bug 1946479: manifests: use manual service account mounts

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@s-urbaniak s-urbaniak deleted the manual-sa-mount branch June 9, 2021 14:27
@s-urbaniak s-urbaniak restored the manual-sa-mount branch June 9, 2021 14:27
@s-urbaniak s-urbaniak deleted the manual-sa-mount branch June 9, 2021 14:27
@s-urbaniak s-urbaniak restored the manual-sa-mount branch June 9, 2021 14:28
This was referenced Jun 10, 2021
Merged
Merged
Merged
@lance5890 lance5890 mentioned this pull request Aug 15, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stlaz stlaz Awaiting requested review from stlaz

@wangke19 wangke19 Awaiting requested review from wangke19

1 more reviewer

@soltysh soltysh soltysh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@stlaz stlaz

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@s-urbaniak @stlaz @openshift-bot @soltysh @openshift-merge-robot