CORS-4220: pass dualstack cluster cidrs as an comma-separated list argument

[tthvo]

kube-controller-manager expects the dualstack cluster and service CIDRs to be passed as comma-separated list arguments according to the kubernetes IPv4/IPv6 documentation.

This ensures the dualstack cluster and service cidrs are indeed passed as comma-separated lists.

Notes

There was previous unmerged work due to inactivity: #745, which has more details on why we need this.

Related Information

Tested with openshift/installer#9930

kube-controller-manager pod logs:

I1031 00:34:49.550011       1 flags.go:64] FLAG: --cluster-cidr="10.128.0.0/14,fd01::/48"
...output-omitted...
I1031 00:34:49.551226       1 flags.go:64] FLAG: --service-cluster-ip-range="172.30.0.0/16,fd02::/112"
...output-omitted...

KubeControllerManager CR is rendered:

$ oc get kubecontrollermanager cluster -o yaml | yq .spec
logLevel: Normal
managementState: Managed
observedConfig:
  extendedArguments:
    cluster-cidr:
      - 10.128.0.0/14,fd01::/48
    service-cluster-ip-range:
      - 172.30.0.0/16,fd02::/112
...output-omitted...

[openshift-ci-robot]

@tthvo: This pull request references CORS-4220 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

Details

In response to this:

kube-controller-manager expects the dualstack cluster and service CIDRs to be passed as comma-separated list arguments according to the kubernetes IPv4/IPv6 documentation.

This ensures the dualstack cluster and service cidrs are indeed passed as comma-separated lists.

Notes

There was previous unmerged work due to inactivity: #745, which has more details on why we need this.

Related Information

Tested with openshift/installer#9930

kube-controller-manager pod logs:

I1031 00:34:49.550011       1 flags.go:64] FLAG: --cluster-cidr="10.128.0.0/14,fd01::/48"
...output-omitted...
I1031 00:34:49.551226       1 flags.go:64] FLAG: --service-cluster-ip-range="172.30.0.0/16,fd02::/112"
...output-omitted...

KubeControllerManager CR is rendered:

$ oc get kubecontrollermanager cluster -o yaml | yq .spec
logLevel: Normal
managementState: Managed
observedConfig:
 extendedArguments:
   cluster-cidr:
     - 10.128.0.0/14,fd01::/48
   service-cluster-ip-range:
     - 172.30.0.0/16,fd02::/112
...output-omitted...

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[tthvo]

/jira refresh

[openshift-ci-robot]

@tthvo: This pull request references CORS-4220 which is a valid jira issue.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[tthvo]

/cc @sadasu @mkowalski

[openshift-ci]

@tthvo: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/okd-scos-e2e-aws-ovn	7d9db03	link	false	/test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[mkowalski]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mkowalski, tthvo
Once this PR has been reviewed and has the lgtm label, please assign ingvagabund for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[tthvo]

/verified by @tthvo

[openshift-ci-robot]

@tthvo: This PR has been marked as verified by @tthvo.

Details

In response to this:

/verified by @tthvo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.