-
Notifications
You must be signed in to change notification settings - Fork 33
OCPBUGS-62517: Add PodDisruptionBudget permissions to cluster-olm-operator #152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The cluster-olm-operator needs permissions to manage PodDisruptionBudgets as they are now part of the static operand assets for catalogd and operator-controller to ensure high availability during upgrades. This change adds the necessary RBAC permissions for the policy API group to create, update, patch, get, list, watch, and delete poddisruptionbudgets. Fixes: openshift/operator-framework-operator-controller#568
|
@jianzhangbjz: This pull request references Jira Issue OCPBUGS-62517, which is valid. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request. The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@jianzhangbjz: This PR was included in a payload test run from openshift/operator-framework-operator-controller#568 |
|
@jianzhangbjz: This PR was included in a payload test run from openshift/operator-framework-operator-controller#568
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/5ff73e90-cc34-11f0-96e3-b060b7dc0c8c-0 |
|
@jianzhangbjz: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest-required |
|
@jianzhangbjz: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
|
/approve |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jianzhangbjz, perdasilva The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@jianzhangbjz: Jira Issue OCPBUGS-62517: Some pull requests linked via external trackers have merged:
The following pull request, linked via external tracker, has not merged: All associated pull requests must be merged or unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with Jira Issue OCPBUGS-62517 has not been moved to the MODIFIED state. This PR is marked as verified. If the remaining PRs listed above are marked as verified before merging, the issue will automatically be moved to VERIFIED after all of the changes from the PRs are available in an accepted nightly payload. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
The cluster-olm-operator needs permissions to manage PodDisruptionBudgets as they are now part of the static operand assets for catalogd and operator-controller to ensure high availability during upgrades.
This change adds the necessary RBAC permissions for the policy API group to create, update, patch, get, list, watch, and delete poddisruptionbudgets.
Fixes: openshift/operator-framework-operator-controller#568 (comment)