Skip to content

Move operand namespace creation to operator rather than CVO #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-robot merged 2 commits into from
Jul 9, 2020
Merged

Move operand namespace creation to operator rather than CVO #153

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
12624fb
migrate operand ns from CVO
sallyom Apr 17, 2020
a794435
generated: update bindata ns.yaml
sallyom Apr 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
migrate operand ns from CVO 
Recovery testing shows that operators that delegate operand ns creation to CVO
take too long (several minutes, at least) to recover after operand ns is deleted.
If other COs depend on health of the operand deployment, this sets a chain reaction
in the cluster.  On the other hand, if ns creation is controlled by the operator,
recovery happens immediately.
  • Loading branch information
@sallyom
sallyom committed Apr 17, 2020
commit 12624fbe9ac98621e95cfb88a2790dd40001e6b7
0 manifests/01_operand-namespace.yaml → ...11.0/openshift-controller-manager/ns.yaml
View file
Open in desktop
File renamed without changes.
1 change: 1 addition & 0 deletions pkg/operator/sync_openshiftcontrollermanager_v311_00.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ func syncOpenShiftControllerManager_v311_00_to_latest(c OpenShiftControllerManag
"v3.11.0/openshift-controller-manager/tokenreview-clusterrolebinding.yaml",
"v3.11.0/openshift-controller-manager/leader-role.yaml",
"v3.11.0/openshift-controller-manager/leader-rolebinding.yaml",
"v3.11.0/openshift-controller-manager/ns.yaml",
"v3.11.0/openshift-controller-manager/old-leader-role.yaml",
"v3.11.0/openshift-controller-manager/old-leader-rolebinding.yaml",
"v3.11.0/openshift-controller-manager/separate-sa-role.yaml",
Expand Down