[release-4.15] OCPBUGS-25664: pkg/cvo/sync_worker: Verification-failure details for unforced updates too #1007
Conversation
…s too We've including verification-failure details for forced updates since 5ad3c14 (pkg/cvo/updatepayload: Event when forcing through a sig-verification failure, 2022-04-07, 2022, openshift#763), but had not been including them in logs or other output in the "we aren't forcing, so this blocks the update's acceptance" case. This commit adds the detail to the Event, so it's available, but keeps only the high-level message in the RetrievePayload status output (which feeds the ReleaseAccepted condition in ClusterVersion), because while the low-level are useful for debugging, they're pretty chatty for condition consumers that are more interested in just knowing basically why the update request isn't being accepted. The newline-to-// replacement is because apparently Event messages truncate at the first newline. I have not tracked down docs or source to back that up, but confirmed it in pre-merge testing [1]. [1]: openshift#1003 (comment)
|
@openshift-cherrypick-robot: Jira Issue OCPBUGS-25055 has been cloned as Jira Issue OCPBUGS-25664. Will retitle bug to link to clone. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
changed the title
openshift-ci-robot
added
jira/valid-reference
|
@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-25664, which is valid. The bug has been moved to the POST state. 6 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
lgtm
|
/label qe-approved |
openshift-ci
bot
added
the
qe-approved
|
@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-25664, which is valid. 6 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
LalatenduMohanty
left a comment
LalatenduMohanty
left a comment
There was a problem hiding this comment.
/label backport-risk-assessed
openshift-ci
bot
added
the
backport-risk-assessed
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: LalatenduMohanty, openshift-cherrypick-robot, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/label cherry-pick-approved |
openshift-ci
bot
added
the
cherry-pick-approved
|
/test unit e2e-hypershift TestRunGraph/mid-task_cancellation_with_work_in_queue_does_not_deadlock is a known flake (https://issues.redhat.com/browse/OCPBUGS-22442) |
|
Nothing does signature verification on HyperShift, at least not at the CVO level, where the HostedControlPlane controller manages the CVO Deployment. /override ci/prow/e2e-hypershift And the past three unit test runs have a pass, a /test unit |
|
@wking: Overrode contexts on behalf of wking: ci/prow/e2e-hypershift DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@openshift-cherrypick-robot: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@openshift-cherrypick-robot: Jira Issue OCPBUGS-25664: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-25664 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[ART PR BUILD NOTIFIER] This PR has been included in build cluster-version-operator-container-v4.15.0-202312210631.p0.g1f8f3b1.assembly.stream for distgit cluster-version-operator. |
|
Fix included in accepted release 4.15.0-0.nightly-2023-12-21-110844 |
8 participants
This is an automated cherry-pick of #1003
/assign wking