Add: autoupdate controller #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/XXL
Contributor
Author
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
yifan-gu
reviewed
Aug 23, 2018
pkg/autoupdate/autoupdate.go
Outdated
| // 5ms, 10ms, 20ms, 40ms, 80ms, 160ms, 320ms, 640ms, 1.3s, 2.6s, 5.1s, 10.2s, 20.4s, 41s, 82s | ||
| maxRetries = 15 | ||
|
|
||
| workQueueKey = "%s/%s" |
There was a problem hiding this comment.
nit: doesn't feel this const is very useful and looks like it's only used in one place...
|
New commits lgtm |
yifan-gu
reviewed
Aug 23, 2018
pkg/autoupdate/autoupdate.go
Outdated
| } | ||
| cvoststatus, ok := obji.(*v1.CVOStatus) | ||
| if !ok { | ||
| return fmt.Errorf("expected *v1.CVOStatus found %t", obji) |
abhinavdahiya
force-pushed
the
autostart
branch
from
5ff6e33 to
437d5a3
Compare
openshift-ci-robot
added
size/L
Contributor
Author
|
/hold cancel @yifan-gu PTAL |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, yifan-gu The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
wking
added a commit
to wking/cluster-version-operator
that referenced
this pull request
Aug 5, 2020
This seems to have been copy-pasted from the machine-config operator in 6c8f725 (cvo: refactor to informers, 2018-08-14, openshift#7) and then from there over to the auto-update package with ad4bd6c (pkg: add autoupdate ctrl, 2018-08-22, openshift#11). Update to generic wording that is less likely to go stale.
wking
added a commit
to wking/cluster-version-operator
that referenced
this pull request
Aug 5, 2020
This seems to have been copy-pasted from the machine-config operator in 6c8f725 (cvo: refactor to informers, 2018-08-14, openshift#7) and then from there over to the auto-update package with ad4bd6c (pkg: add autoupdate ctrl, 2018-08-22, openshift#11). Update to generic wording that is less likely to go stale.
wking
added a commit
to wking/cluster-version-operator
that referenced
this pull request
Aug 5, 2020
This seems to have been copy-pasted from the machine-config operator in 6c8f725 (cvo: refactor to informers, 2018-08-14, openshift#7) and then from there over to the auto-update package with ad4bd6c (pkg: add autoupdate ctrl, 2018-08-22, openshift#11). Update to generic wording that is less likely to go stale.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
autoupdate controller sets the DesiredUpdate for CVOConfig to the greatest available version from OperatorStatus AvailabeUpdates.
Requires #10
/cc @crawford @smarterclayton
/assign @crawford @smarterclayton