Skip to content

[OCPBUGS-57585]CVO protects /metrics with kube-rbac-proxy #1214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hongkailiu wants to merge 7 commits into from
Closed

[OCPBUGS-57585]CVO protects /metrics with kube-rbac-proxy #1214

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
955e63b
CVO container: Serve HTTP instead of HTTPS
hongkailiu Jul 21, 2025
834d079
Define kube-rbac-proxy sidecar
hongkailiu Jul 22, 2025
3436f1c
Update vendor
hongkailiu Jul 22, 2025
416030f
debug: simplify securityContext
hongkailiu Jul 22, 2025
937be8e
debug: allow-paths and readOnly-volumeMounts
hongkailiu Jul 22, 2025
44a5bd5
debug: mount kube-api-access
hongkailiu Jul 22, 2025
4da6ccc
debug: fix client-ca-file
hongkailiu Jul 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
debug: allow-paths and readOnly-volumeMounts
  • Loading branch information
@hongkailiu
hongkailiu committed Jul 22, 2025
commit 937be8e98fa49ed8a4b8cbabba93b8301f8711f3
6 changes: 3 additions & 3 deletions install/0000_00_cluster-version-operator_03_deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,12 +27,12 @@ spec:
- args:
- --logtostderr
- --secure-listen-address=[$(IP)]:9099
- --tls-cipher-suites=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256,TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256,TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384,TLS_ECDHE_ECDSA_WITH_AES_256_GCM_SHA384,TLS_ECDHE_RSA_WITH_CHACHA20_POLY1305,TLS_ECDHE_ECDSA_WITH_CHACHA20_POLY1305
- --upstream=http://127.0.0.1:9099/
- --tls-cert-file=/etc/tls/serving-cert/tls.crt
- --tls-private-key-file=/etc/tls/serving-cert/tls.key
- --client-ca-file=/etc/tls/service-ca/client-ca.crt
- --config-file=/etc/kube-rbac-proxy/config.yaml
- --allow-paths=/metrics
env:
- name: IP
valueFrom:
Expand All @@ -57,10 +57,10 @@ spec:
volumeMounts:
- mountPath: /etc/tls/serving-cert
name: serving-cert
readOnly: false
readOnly: true
- mountPath: /etc/tls/service-ca
name: service-ca
readOnly: false
readOnly: true
- mountPath: /etc/kube-rbac-proxy
name: secret-kube-rbac-proxy-metric
readOnly: true
Expand Down
6 changes: 3 additions & 3 deletions pkg/payload/testdata/TestRenderManifest_expected_cvo_deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,12 +27,12 @@ spec:
- args:
- --logtostderr
- --secure-listen-address=[$(IP)]:9099
- --tls-cipher-suites=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256,TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256,TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384,TLS_ECDHE_ECDSA_WITH_AES_256_GCM_SHA384,TLS_ECDHE_RSA_WITH_CHACHA20_POLY1305,TLS_ECDHE_ECDSA_WITH_CHACHA20_POLY1305
- --upstream=http://127.0.0.1:9099/
- --tls-cert-file=/etc/tls/serving-cert/tls.crt
- --tls-private-key-file=/etc/tls/serving-cert/tls.key
- --client-ca-file=/etc/tls/service-ca/client-ca.crt
- --config-file=/etc/kube-rbac-proxy/config.yaml
- --allow-paths=/metrics
env:
- name: IP
valueFrom:
Expand All @@ -57,10 +57,10 @@ spec:
volumeMounts:
- mountPath: /etc/tls/serving-cert
name: serving-cert
readOnly: false
readOnly: true
- mountPath: /etc/tls/service-ca
name: service-ca
readOnly: false
readOnly: true
- mountPath: /etc/kube-rbac-proxy
name: secret-kube-rbac-proxy-metric
readOnly: true
Expand Down