Skip to content

NO-JIRA: Move constants of ClusterStatusConditionType into one place #1252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-bot merged 6 commits into from
Nov 21, 2025
Merged

NO-JIRA: Move constants of ClusterStatusConditionType into one place #1252

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0f873c1
Move constants of ClusterStatusConditionType into one place
hongkailiu Oct 29, 2025
ce96105
Fix unit tests
hongkailiu Oct 29, 2025
bfc7f69
Remove redundant type casting
hongkailiu Oct 29, 2025
76f0dd4
Rename DesiredReleaseAccepted to ReleaseAccepted
hongkailiu Nov 19, 2025
cea8161
Rename setDesiredReleaseAcceptedCondition to setReleaseAcceptedCondition
hongkailiu Nov 19, 2025
d5212c0
Move UpgradeableUpgradeInProgress into the internal pkg
hongkailiu Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Move UpgradeableUpgradeInProgress into the internal pkg
  • Loading branch information
@hongkailiu
hongkailiu committed Nov 19, 2025
commit d5212c0e014c941d73bcd866a0bdf685aef5a0e7
2 changes: 1 addition & 1 deletion pkg/cvo/upgradeable.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,7 @@ type upgradeInProgressUpgradeable struct {

func (check *upgradeInProgressUpgradeable) Check() *configv1.ClusterOperatorStatusCondition {
cond := &configv1.ClusterOperatorStatusCondition{
Type: "UpgradeableUpgradeInProgress",
Type: internal.UpgradeableUpgradeInProgress,
Status: configv1.ConditionTrue,
}

Expand Down
3 changes: 3 additions & 0 deletions pkg/internal/constants.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,4 +67,7 @@ const (
// UpgradeableClusterVersionOverrides is False if there are overrides in the Cluster Version, and thus update to the next minor
// version is blocked.
UpgradeableClusterVersionOverrides configv1.ClusterStatusConditionType = "UpgradeableClusterVersionOverrides"

// UpgradeableUpgradeInProgress is True if an update is in progress
UpgradeableUpgradeInProgress configv1.ClusterStatusConditionType = "UpgradeableUpgradeInProgress"
)