Skip to content

WIP: Metrics mTLS #1271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
DavidHurta wants to merge 8 commits into
base: main
Choose a base branch
from
+7,188 −2,705
Draft

WIP: Metrics mTLS #1271

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
7d2ed9a
Run `go mod tidy & go mod vendor`
DavidHurta Dec 10, 2025
34371e0
pkg/cvo/metrics: Refactor using dynamiccertificates package
DavidHurta Dec 10, 2025
35e5cab
pkg/cvo/metrics: Use mTLS
DavidHurta Dec 11, 2025
b54010d
install/servicemonitor: Instruct Prometheus to use mTLS instead of be…
DavidHurta Dec 10, 2025
f26bd93
pkg/cvo/metrics: Authorize using CN verification
DavidHurta Dec 11, 2025
e7705e2
pkg/cvo/metrics_test: Test CN verification authorization handler
DavidHurta Dec 10, 2025
b907220
pkg/start/start: Use directly HyperShift flag
DavidHurta Dec 12, 2025
920ad71
pkg/cvo/metrics: Introduce options to disable granularly authn/authz
DavidHurta Dec 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
pkg/start/start: Use directly HyperShift flag
  • Loading branch information
@DavidHurta
DavidHurta committed Dec 12, 2025
commit b9072206eb1638c4166566f7d003a4dc32214dea
2 changes: 1 addition & 1 deletion pkg/start/start.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -350,7 +350,7 @@ func (o *Options) run(ctx context.Context, controllerCtx *Context, lock resource
resultChannelCount++
go func() {
defer utilruntime.HandleCrash()
disableMetricsAuth := o.InjectClusterIdIntoPromQL // this is wired to the "--hypershift" flag, so when hypershfit is no, we disableMetricsAuth
disableMetricsAuth := o.HyperShift
err := cvo.RunMetrics(postMainContext, shutdownContext, o.ListenAddr, o.ServingCertFile, o.ServingKeyFile, restConfig, disableMetricsAuth)
resultChannel <- asyncResult{name: "metrics server", error: err}
}()
Expand Down