sync: Serve cluster operator gets from the cache lister #132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reduces the amount of API calls we make significantly when polling, which reduces load on API server and also doesn't consume as much of our client rate limit. This does not impact correctness because we're level driven for continuity and a subsequent sync loop will already handle this.
openshift-ci-robot
added
approved
Contributor
Author
|
/assign @abhinavdahiya |
Contributor
Author
|
suspicious flake - saw this in the other Pr as well /retest |
Contributor
Author
|
/test e2e-aws |
2 similar comments
Contributor
Author
|
/test e2e-aws |
Contributor
Author
|
/test e2e-aws |
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, smarterclayton The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduces the amount of API calls we make significantly when polling,
which reduces load on API server and also doesn't consume as much of
our client rate limit.
This does not impact correctness because we're level driven for
continuity and a subsequent sync loop will already handle this.
Extracted from #131