Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/resourceapply/core.go
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,10 @@ func ApplyService(client coreclientv1.ServicesGetter, required *corev1.Service)

modified := pointer.BoolPtr(false)
resourcemerge.EnsureObjectMeta(modified, &existing.ObjectMeta, required.ObjectMeta)
resourcemerge.EnsureServicePorts(modified, &existing.Spec.Ports, required.Spec.Ports)
selectorSame := equality.Semantic.DeepEqual(existing.Spec.Selector, required.Spec.Selector)
typeSame := equality.Semantic.DeepEqual(existing.Spec.Type, required.Spec.Type)

if selectorSame && typeSame && !*modified {
return nil, false, nil
}
Expand Down
45 changes: 45 additions & 0 deletions lib/resourcemerge/core.go
Original file line number Diff line number Diff line change
Expand Up @@ -202,6 +202,51 @@ func ensureContainerPort(modified *bool, existing *corev1.ContainerPort, require
}
}

func EnsureServicePorts(modified *bool, existing *[]corev1.ServicePort, required []corev1.ServicePort) {
for i, existingServicePort := range *existing {
var existingCurr *corev1.ServicePort
for _, requiredServicePort := range required {
if existingServicePort.Name == requiredServicePort.Name {
existingCurr = &(*existing)[i]
ensureServicePort(modified, existingCurr, requiredServicePort)
break
}
}
if existingCurr == nil {
*modified = true
*existing = append((*existing)[:i], (*existing)[i+1:]...)
}
}

for _, requiredServicePort := range required {
match := false
for _, existingServicePort := range *existing {
if existingServicePort.Name == requiredServicePort.Name {
match = true
break
}
}
if !match {
*modified = true
*existing = append(*existing, requiredServicePort)
}
}
}

func ensureServicePort(modified *bool, existing *corev1.ServicePort, required corev1.ServicePort) {
ensureServicePortDefaults(&required)
if !equality.Semantic.DeepEqual(required, *existing) {
*modified = true
*existing = required
}
}

func ensureServicePortDefaults(servicePort *corev1.ServicePort) {
if servicePort.Protocol == "" {
servicePort.Protocol = corev1.ProtocolTCP
}
}

func ensureVolumeMount(modified *bool, existing *corev1.VolumeMount, required corev1.VolumeMount) {
if !equality.Semantic.DeepEqual(required, *existing) {
*modified = true
Expand Down
Loading