Bug 1798049: lib/resourcemerge/core: Fix panic on container/port removal #313

openshift-cherrypick-robot · 2020-02-04T09:16:02Z

This is an automated cherry-pick of #282

/assign wking

Avoid: $ go test ./lib/resourcemerge/ panic: runtime error: index out of range [recovered] panic: runtime error: index out of range goroutine 38 [running]: testing.tRunner.func1(0xc0001ab000) .../sdk/go1.12.9/src/testing/testing.go:830 +0x392 panic(0xccb520, 0x163f880) .../sdk/go1.12.9/src/runtime/panic.go:522 +0x1b5 github.com/openshift/cluster-version-operator/lib/resourcemerge.ensureContainers(0xc0000bbd57, 0xc0001d4040, 0xc0001cd760, 0x1, 0x1) .../lib/go/src/github.com/openshift/cluster-version-operator/lib/resourcemerge/core.go:69 +0x840 github.com/openshift/cluster-version-operator/lib/resourcemerge.ensurePodSpec(0xc0001c5d57, 0xc0001d4010, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0xc0001cd760, 0x1, ...) .../lib/go/src/github.com/openshift/cluster-version-operator/lib/resourcemerge/core.go:28 +0xc6 github.com/openshift/cluster-version-operator/lib/resourcemerge.TestEnsurePodSpec.func1(0xc0001ab000) .../lib/go/src/github.com/openshift/cluster-version-operator/lib/resourcemerge/core_test.go:276 +0xc7 testing.tRunner(0xc0001ab000, 0xc0001d8770) .../sdk/go1.12.9/src/testing/testing.go:865 +0xc0 created by testing.(*T).Run .../sdk/go1.12.9/src/testing/testing.go:916 +0x35a FAIL github.com/openshift/cluster-version-operator/lib/resourcemerge 0.010s (with the core_test.go but the old core.go) when removing an entry mutated the existing slice without re-entering the: for i, whatever := range *existing With this commit, we iterate from the back of the existing slice, so any removals affect indexes that we've already covered. For both containers and service ports, any appends happen later in the function, so we don't need to worry about slice expansion at this point. The buggy logic was originally from 3d1ad76 (Remove containers if requested in Update, 2019-04-26, openshift#178).

openshift-ci-robot · 2020-02-04T09:16:05Z

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1783221, which is invalid:

expected the bug to target the "4.3.z" release, but it targets "4.4.0" instead
expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is MODIFIED instead
expected Bugzilla bug 1783221 to depend on a bug in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

[release-4.3] Bug 1783221: lib/resourcemerge/core: Fix panic on container/port removal

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sdodson · 2020-02-04T13:30:35Z

/retitle Bug 1798049: lib/resourcemerge/core: Fix panic on container/port removal

openshift-ci-robot · 2020-02-04T13:30:40Z

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1798049, which is invalid:

expected dependent Bugzilla bug 1783221 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1798049: lib/resourcemerge/core: Fix panic on container/port removal

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

wking · 2020-02-06T21:56:30Z

/bugzilla refresh

openshift-ci-robot · 2020-02-06T21:56:36Z

@wking: This pull request references Bugzilla bug 1798049, which is valid.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

wking · 2020-02-06T21:56:40Z

/lgtm

openshift-ci-robot · 2020-02-06T21:57:12Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2020-02-12T14:06:29Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-02-12T14:18:58Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-02-12T16:29:35Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-02-12T19:06:03Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-02-12T20:23:12Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-02-12T20:49:20Z

/retest

Please review the full test history for this PR and help us cut down flakes.

wking · 2020-02-12T21:46:30Z

Previous upgrade job failed with:

error: unable to read image registry.svc.ci.openshift.org/ci-op-v7kbrq6z/stable-initial@sha256:3e9862e54c6bff98c18445858684f77ccd8ae88057c18eaa2a831f1d120dda15: received unexpected HTTP status: 504 Gateway Time-out

which is rhbz#1792002.

openshift-bot · 2020-02-12T22:37:24Z

/retest

Please review the full test history for this PR and help us cut down flakes.

wking · 2020-02-13T00:28:19Z

Previous upgrade job failed with:

fail [github.com/openshift/origin/test/extended/util/disruption/controlplane/controlplane.go:56]: Feb 12 23:39:25.180: API was unreachable during upgrade for at least 2m43s:

That's rhbz#1801885.

openshift-bot · 2020-02-13T01:21:45Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-02-13T02:00:46Z

/retest

Please review the full test history for this PR and help us cut down flakes.

wking · 2020-02-13T03:33:46Z

Previous upgrade job failed with:

fail [github.com/openshift/origin/test/extended/util/disruption/controlplane/controlplane.go:56]: Feb 13 02:14:33.217: API was unreachable during upgrade for at least 2m39s:

openshift-bot · 2020-02-13T03:45:35Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-02-13T03:58:03Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-02-13T05:40:24Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-02-13T05:53:21Z

/retest

Please review the full test history for this PR and help us cut down flakes.

wking · 2020-02-13T05:53:23Z

And now AWS is falling over:

 level=error msg="Error: Error waiting for instance (i-015afffe2b30481f7) to become ready: Failed to reach target state. Reason: Server.InternalError: Internal error on launch"
level=error
level=error msg="  on ../tmp/openshift-install-080478465/bootstrap/main.tf line 116, in resource \"aws_instance\" \"bootstrap\":"
level=error msg=" 116: resource \"aws_instance\" \"bootstrap\" {"

Eventually we'll bust through these flakes. I hope... :p

openshift-bot · 2020-02-13T06:45:27Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-02-13T06:58:25Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-02-13T08:42:36Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-02-13T09:09:07Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-02-13T11:31:30Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-02-13T14:59:28Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-02-13T15:11:53Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-02-13T17:21:51Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-02-13T17:34:49Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-02-13T17:47:57Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-02-13T19:45:05Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-02-13T20:50:07Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-02-13T21:03:09Z

/retest

Please review the full test history for this PR and help us cut down flakes.

sdodson · 2020-02-13T21:16:32Z

/hold
Registry problems? Perhaps allowing the namespace to expire will help? Clear this in a few hours if i haven't already.

wking · 2020-02-13T23:24:21Z

/hold cancel

We're green?!

openshift-ci-robot · 2020-02-14T00:48:16Z

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged. Bugzilla bug 1798049 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1798049: lib/resourcemerge/core: Fix panic on container/port removal

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot assigned wking Feb 4, 2020

openshift-cherrypick-robot mentioned this pull request Feb 4, 2020

Bug 1783221: lib/resourcemerge/core: Fix panic on container/port removal #282

Merged

openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Feb 4, 2020

openshift-ci-robot requested review from abhinavdahiya and wking February 4, 2020 09:16

openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 4, 2020

openshift-ci-robot changed the title ~~[release-4.3] Bug 1783221: lib/resourcemerge/core: Fix panic on container/port removal~~ Bug 1798049: lib/resourcemerge/core: Fix panic on container/port removal Feb 4, 2020

openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Feb 6, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 6, 2020

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 6, 2020

mfojtik added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Feb 12, 2020

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 13, 2020

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 13, 2020

openshift-merge-robot merged commit e44055f into openshift:release-4.3 Feb 14, 2020

Bug 1798049: lib/resourcemerge/core: Fix panic on container/port removal #313

Bug 1798049: lib/resourcemerge/core: Fix panic on container/port removal #313

Uh oh!

Conversation

openshift-cherrypick-robot commented Feb 4, 2020

Uh oh!

openshift-ci-robot commented Feb 4, 2020

Uh oh!

sdodson commented Feb 4, 2020

Uh oh!

openshift-ci-robot commented Feb 4, 2020

Uh oh!

wking commented Feb 6, 2020

Uh oh!

openshift-ci-robot commented Feb 6, 2020

Uh oh!

wking commented Feb 6, 2020

Uh oh!

openshift-ci-robot commented Feb 6, 2020

Uh oh!

openshift-bot commented Feb 12, 2020

Uh oh!

openshift-bot commented Feb 12, 2020

Uh oh!

openshift-bot commented Feb 12, 2020

Uh oh!

openshift-bot commented Feb 12, 2020

Uh oh!

openshift-bot commented Feb 12, 2020

Uh oh!

openshift-bot commented Feb 12, 2020

Uh oh!

wking commented Feb 12, 2020

Uh oh!

openshift-bot commented Feb 12, 2020

Uh oh!

wking commented Feb 13, 2020

Uh oh!

openshift-bot commented Feb 13, 2020

Uh oh!

openshift-bot commented Feb 13, 2020

Uh oh!

wking commented Feb 13, 2020

Uh oh!

openshift-bot commented Feb 13, 2020

Uh oh!

openshift-bot commented Feb 13, 2020

Uh oh!

openshift-bot commented Feb 13, 2020

Uh oh!

openshift-bot commented Feb 13, 2020

Uh oh!

wking commented Feb 13, 2020

Uh oh!

openshift-bot commented Feb 13, 2020

Uh oh!

openshift-bot commented Feb 13, 2020

Uh oh!

openshift-bot commented Feb 13, 2020

Uh oh!

openshift-bot commented Feb 13, 2020

Uh oh!

openshift-bot commented Feb 13, 2020

Uh oh!

openshift-bot commented Feb 13, 2020

Uh oh!

openshift-bot commented Feb 13, 2020

Uh oh!

openshift-bot commented Feb 13, 2020

Uh oh!

openshift-bot commented Feb 13, 2020

Uh oh!

openshift-bot commented Feb 13, 2020

Uh oh!

openshift-bot commented Feb 13, 2020

Uh oh!

openshift-bot commented Feb 13, 2020

Uh oh!

openshift-bot commented Feb 13, 2020

Uh oh!