Skip to content

Bug 1823306: pkg/cvo/upgradeable: Mention "between minor versions" #356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
May 7, 2020
Merged

Bug 1823306: pkg/cvo/upgradeable: Mention "between minor versions" #356

openshift-merge-robot merged 1 commit into from
May 7, 2020

Conversation

@wking
Copy link
Member

@wking wking commented Apr 22, 2020

Catching the message strings up with the softening from bcd58d8 (#291).

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 22, 2020

@wking: This pull request references Bugzilla bug 1823306, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Details

In response to this:

Bug 1823306: pkg/cvo/upgradeable: Mention "between minor versions"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Apr 22, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 22, 2020
@wking wking force-pushed the log-upgradeable-blocks-minor branch from a9bb055 to 9e76c64 Compare May 6, 2020 22:41
@wking
Copy link
Member Author

wking commented May 6, 2020

Fixed at least some of the unit failures and rebased onto master with a9bb055 -> 9e76c64.

@jottofar
Copy link
Contributor

jottofar commented May 6, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 6, 2020
@wking
pkg/cvo/upgradeable: Mention "between minor versions"
b4d6f35 
Catching the message strings up with the softening from bcd58d8
(loosen upgradeable condition to allow z-level upgrades, 2020-01-02, openshift#291),
addressing [1].

[1]: https://bugzilla.redhat.com/show_bug.cgi?id=1823306
@wking wking force-pushed the log-upgradeable-blocks-minor branch from 9e76c64 to b4d6f35 Compare May 6, 2020 23:08
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label May 6, 2020
@jottofar
Copy link
Contributor

jottofar commented May 6, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 6, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 6, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jottofar, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 356db86 into openshift:master May 7, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 7, 2020

@wking: All pull requests linked via external trackers have merged: openshift/cluster-version-operator#356. Bugzilla bug 1823306 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1823306: pkg/cvo/upgradeable: Mention "between minor versions"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wking wking deleted the log-upgradeable-blocks-minor branch May 8, 2020 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jottofar jottofar Awaiting requested review from jottofar

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@jottofar jottofar

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wking @openshift-ci-robot @jottofar @openshift-merge-robot