Skip to content

Bug 1822513: Determine current version by checking for status completed #394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Jul 22, 2020
Merged

Bug 1822513: Determine current version by checking for status completed #394

openshift-merge-robot merged 1 commit into from
Jul 22, 2020

Conversation

@jottofar
Copy link
Contributor

@jottofar jottofar commented Jun 26, 2020

No description provided.

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jun 26, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jun 26, 2020

@jottofar: This pull request references Bugzilla bug 1822513, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Details

In response to this:

Bug 1822513: WIP:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 26, 2020
@jottofar
Copy link
Contributor Author

jottofar commented Jun 26, 2020

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 26, 2020
@jottofar jottofar force-pushed the bug-1822513 branch 8 times, most recently from 19637c5 to ef0f191 Compare July 2, 2020 19:14
@jottofar
Copy link
Contributor Author

jottofar commented Jul 2, 2020

/retitle Bug 1822513: Cluster version history addtions do not contain version

@openshift-ci-robot openshift-ci-robot changed the title Bug 1822513: WIP: Bug 1822513: Cluster version history addtions do not contain version Jul 2, 2020
@jottofar
Copy link
Contributor Author

jottofar commented Jul 2, 2020

/test unit

@jottofar
Copy link
Contributor Author

jottofar commented Jul 2, 2020

/retitle Bug 1822513: Cluster version history additions do not contain version

@openshift-ci-robot openshift-ci-robot changed the title Bug 1822513: Cluster version history addtions do not contain version Bug 1822513: Cluster version history additions do not contain version Jul 2, 2020
@jottofar
Copy link
Contributor Author

jottofar commented Jul 2, 2020

/retest

@jottofar
Copy link
Contributor Author

jottofar commented Jul 6, 2020

/unhold

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 6, 2020
@jottofar
Copy link
Contributor Author

jottofar commented Jul 6, 2020

/retest

@jottofar
Copy link
Contributor Author

jottofar commented Jul 6, 2020

/test images

@jottofar
Copy link
Contributor Author

jottofar commented Jul 6, 2020

/test e2e-aws

@LalatenduMohanty
Copy link
Member

LalatenduMohanty commented Jul 6, 2020

/assign @LalatenduMohanty

LalatenduMohanty
LalatenduMohanty approved these changes Jul 20, 2020
View reviewed changes
Copy link
Member

@LalatenduMohanty LalatenduMohanty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 20, 2020
@LalatenduMohanty
Copy link
Member

LalatenduMohanty commented Jul 20, 2020 •
edited
Loading

/hold
Feel free to remove the hold after addressing @wking 's comment

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 20, 2020
@jottofar
Bug 1822513: Determine current version by checking for status completed
a21d201 
Preconditions such as ClusterVersion overrides should block all upgrades
including z-level upgrades. However other preconditions should not be
block z-level upgrades.

Currently, when upgrades are performed using `oc adm upgrade` CVO will
check if it is a z-level upgrade by comaparing the minor level version
of the desired update with the minor level version of the currently
installed version. The currently installed version is determined by
simply using the first entry in version history however this is
incorrect since that entry will be the version being upgraded to, i.e.
the desired version. A side-effect of this is that when the
`--to-image option` is used, this first entry will have an empty version
string and therefore the z-level upgrade check will always return false
and preconditions are always checked.
Instead, this change iterates through the version history until it finds
the first version with update State of Completed which will be the
currently installed version. If no Completed version is found the
originally installed version is returned.
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jul 21, 2020
@jottofar
Copy link
Contributor Author

jottofar commented Jul 21, 2020

/unhold

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 21, 2020
LalatenduMohanty
LalatenduMohanty approved these changes Jul 21, 2020
View reviewed changes
Copy link
Member

@LalatenduMohanty LalatenduMohanty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 21, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 21, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jottofar, LalatenduMohanty

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [LalatenduMohanty,jottofar]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jottofar
Copy link
Contributor Author

jottofar commented Jul 21, 2020

/retest

@openshift-bot
Copy link
Contributor

openshift-bot commented Jul 21, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

11 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Jul 21, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jul 21, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jul 21, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jul 22, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jul 22, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jul 22, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jul 22, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jul 22, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jul 22, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jul 22, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jul 22, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 22, 2020 •
edited
Loading

@jottofar: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-gcp-upgrade 121b459 link /test e2e-gcp-upgrade
ci/prow/e2e-gcp 121b459 link /test e2e-gcp

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jul 22, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

openshift-bot commented Jul 22, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit b2b3add into openshift:master Jul 22, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 22, 2020

@jottofar: All pull requests linked via external trackers have merged: openshift/cluster-version-operator#394. Bugzilla bug 1822513 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1822513: Determine current version by checking for status completed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wking wking wking left review comments

+1 more reviewer

@LalatenduMohanty LalatenduMohanty LalatenduMohanty approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@LalatenduMohanty LalatenduMohanty

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@jottofar @openshift-ci-robot @LalatenduMohanty @openshift-bot @wking @openshift-merge-robot