lib/resourcebuilder/apps: Explicit mode instead of 'Generation > 1' #401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

openshift-merge-robot merged 1 commit into openshift:master from wking:explicit-app-install-mode

Jul 11, 2020

Member

wking commented Jul 8, 2020

deploymentBuilder and daemonsetBuilder grow mode properties. They had been using actual.Generation > 1 as a proxy for "post-install" since 14fab0b (#26), but generation 1 is just "we haven't changed the object since it was created", not "we're installing a fresh cluster". For example, a new Deployment or DaemonSet could be added as part of a cluster update, and we don't want special install-time "we don't care about specific manifest failures" then.

Spun out from #400 at @smarterclayton's request.

openshift-ci-robot requested review from LalatenduMohanty and abhinavdahiya

July 8, 2020 00:58

openshift-ci-robot added the approved label

wking mentioned this pull request

lib/resourcebuilder: Replace wait-for with single-shot "is it alive now?" #400

Merged


          lib/resourcebuilder/apps: Explicit mode instead of 'Generation > 1'

844c3aa

deploymentBuilder and daemonsetBuilder grow mode properties.  They had
been using 'actual.Generation > 1' as a proxy for "post-install" since
14fab0b (add generic 2-way merge handler for random types,
2018-09-27, openshift#26), but generation 1 is just "we haven't changed the
object since it was created", not "we're installing a fresh cluster".
For example, a new Deployment or DaemonSet could be added as part of a
cluster update, and we don't want special install-time "we don't care
about specific manifest failures" then.

wking force-pushed the explicit-app-install-mode branch from 1e38ab0 to 844c3aa Compare

July 8, 2020 01:41

Contributor

jottofar commented Jul 8, 2020

/lgtm

openshift-ci-robot assigned jottofar

openshift-ci-robot added the lgtm label

Contributor

openshift-bot commented Jul 8, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments

Contributor

openshift-bot commented Jul 8, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jul 8, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Member Author

wking commented Jul 9, 2020

Service disruption

/retest

Contributor

openshift-bot commented Jul 9, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

16 similar comments

Contributor

openshift-bot commented Jul 9, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jul 9, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jul 9, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jul 9, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jul 9, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jul 9, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jul 9, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jul 9, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jul 9, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jul 9, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jul 9, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jul 9, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jul 9, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jul 9, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jul 9, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jul 9, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jul 10, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

21 similar comments

Contributor

openshift-bot commented Jul 10, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jul 10, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jul 11, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jul 11, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jul 11, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jul 11, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jul 11, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jul 11, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jul 11, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jul 11, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jul 11, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jul 11, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jul 11, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jul 11, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jul 11, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jul 11, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jul 11, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jul 11, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jul 11, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jul 11, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jul 11, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Member Author

wking commented Jul 11, 2020

/override e2e-gcp-upgrade

We don't need that anymore, it's now the genrically-named e2e-upgrade.

Contributor

openshift-ci-robot commented Jul 11, 2020

@wking: /override requires a failed status context to operate on.
The following unknown contexts were given:

e2e-gcp-upgrade

Only the following contexts were expected:

ci/prow/e2e
ci/prow/e2e-aws
ci/prow/e2e-aws-upgrade
ci/prow/e2e-gcp
ci/prow/e2e-gcp-upgrade
ci/prow/e2e-upgrade
ci/prow/images
ci/prow/integration
ci/prow/unit
tide

Details

In response to this:

/override e2e-gcp-upgrade

We don't need that anymore, it's now the genrically-named e2e-upgrade.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Member Author

wking commented Jul 11, 2020

/override ci/prow/e2e-gcp-upgrade

Contributor

openshift-ci-robot commented Jul 11, 2020

@wking: Overrode contexts on behalf of wking: ci/prow/e2e-gcp-upgrade

Details

In response to this:

/override ci/prow/e2e-gcp-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-merge-robot merged commit 2c00744 into openshift:master

wking deleted the explicit-app-install-mode branch

July 11, 2020 14:18

Member

sdodson commented Jul 11, 2020

/override e2e-gcp-upgrade

We don't need that anymore, it's now the genrically-named e2e-upgrade.

I think /skip is what's meant to be used when tests are removed or made non blocking but I guess that worked too.

Member Author

wking commented Jul 11, 2020

I tried /skip up here, but maybe that was before the e2e-gcp -> e2e change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels