Bug 1797123: pkg/cvo: Separate ConfigMap informer for openshift-config-managed #441
Conversation
With c9fab43 (pkg/cvo: Fetch proxy CA certs from openshift-config-managed/trusted-ca-bundle, 2020-01-31, openshift#311), I attempted to pivot to loading the TLS configration from the openshift-config-managed namespace. But I hadn't realized that cmConfigInformer was scoped to the openshift-config namespace, so attempts to retrieve trusted-ca-bundle failed via the "not found" no-op path regardless of whether the ConfigMap actually existed. With this commit, I create a new informer for the openshift-config-managed namespace, so we can successfully retrieve the ConfigMap when it exists. An alternative approach would be to drop the informers.WithNamespace filter. My impression is that having two namespace-filtered informers will be more efficient than a single unfiltered informer, but I'm not really sure.
openshift-ci-robot
added
bugzilla/severity-medium
|
@wking: This pull request references Bugzilla bug 1797123, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
approved
|
/retest |
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
I am not sure which is the better way to move ahead. So going ahead with the current implementation. |
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jottofar, LalatenduMohanty, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@wking: All pull requests linked via external trackers have merged: openshift/cluster-version-operator#441, openshift/cluster-version-operator#311. Bugzilla bug 1797123 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
5 participants
With c9fab43 (#311), I attempted to pivot to loading the TLS configration from the
openshift-config-managednamespace. But I hadn't realized thatcmConfigInformerwas scoped to theopenshift-confignamespace, so attempts to retrievetrusted-ca-bundlefailed via the "not found" no-op path regardless of whether the ConfigMap actually existed. With this commit, I create a new informer for theopenshift-config-managednamespace, so we can successfully retrieve the ConfigMap when it exists.An alternative approach would be to drop the
informers.WithNamespacefilter. My impression is that having two namespace-filtered informers will be more efficient than a single unfiltered informer, but I'm not really sure.