Skip to content

Conversation

@dmage
Copy link

@dmage dmage commented Nov 7, 2018

No description provided.

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dmage
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: abhinavdahiya

If they are not already assigned, you can assign the PR to them by writing /assign @abhinavdahiya in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 7, 2018
@dmage
Copy link
Author

dmage commented Nov 7, 2018

For some reason informer-gen wants to use namespaces for the ClusterVersion resource. So ./hack/verify-codegen.sh fails.

@smarterclayton
Copy link
Contributor

/hold

I'm going to move this to openshift/api (maybe tomorrow morning), in which case we would then vendor it back.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 7, 2018
@bparees
Copy link
Contributor

bparees commented Nov 9, 2018

@smarterclayton are you close to having this moved? this current half-way moved state appears to be blocking some progress @gabemontero is trying to make, or there is a subtly we don't understand.

@smarterclayton
Copy link
Contributor

openshift/api#127 is the move PR

@abhinavdahiya
Copy link
Contributor

/close in favor of #55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants