install/0000_90_cluster-version-operator_02_servicemonitor: Alert summary/descriptions #547

wking · 2021-04-13T23:37:29Z

Catching up with upstream's move from message, as documented here.

wking · 2021-04-14T20:03:12Z

CC @openshift/sre-alert-sme, in case you want to review the proposed changes.

install/0000_90_cluster-version-operator_02_servicemonitor.yaml

dofinn · 2021-04-14T21:57:13Z

install/0000_90_cluster-version-operator_02_servicemonitor.yaml

    - alert: ClusterOperatorDown
      annotations:
-        message: Cluster operator {{ "{{ $labels.name }}" }} has not been available for 10 minutes. Operator may be down or disabled, cluster will not be kept up to date and upgrades will not be possible.
+        summary: Cluster operator has not been available for 10 minutes.


There is inconsistency here with
Cluster version operator vs Cluster operator https://github.com/openshift/cluster-version-operator/pull/547/files#diff-fabad9e1d73a4f70c3d47836ed62e1982b1c6fbb947fce9a633b9cb0a98ecb24R43

I would suggest updating all refs to use Cluster version operator.

ClusterVersionOperatorDown is only about the cluster-version operator deployment, so Cluster version operator is appropriate there.

ClusterOperatorDown and ClusterOperatorDegraded are about about the conditions on ClusterVersion and ClusterOperators, so the more generic Cluster operator is appropriate there.

LalatenduMohanty

/lgtm

/hold for SRE folks approval

dofinn · 2021-04-20T21:05:40Z

/lgtm

openshift-ci-robot · 2021-04-20T21:05:53Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dofinn, LalatenduMohanty, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [LalatenduMohanty,wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LalatenduMohanty · 2021-05-04T13:03:40Z

/hold cancel

LalatenduMohanty · 2021-05-04T13:04:04Z

/retest

wking · 2021-05-04T13:51:18Z

/hold

No bug, so we need to wait until 4.8 forks off and master opens for 4.9.

openshift-ci · 2021-05-11T14:05:30Z

@wking: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

…mary/descriptions Catching up with upstream's move from 'message', as documented in [1]. [1]: https://github.com/monitoring-mixins/docs/pull/10/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5R183

wking · 2021-06-14T18:15:54Z

Rebased onto master now that master is open for 4.9.

/hold cancel

LalatenduMohanty

/lgtm

openshift-ci · 2021-06-14T18:17:43Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dofinn, LalatenduMohanty, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [LalatenduMohanty,wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

wking · 2021-06-15T16:12:45Z

The HAProxy router should set Forwarded headers appropriately is unrelated.

/override ci/prow/e2e-agnostic

openshift-ci · 2021-06-15T16:12:54Z

@wking: Overrode contexts on behalf of wking: ci/prow/e2e-agnostic

Details

In response to this:

The HAProxy router should set Forwarded headers appropriately is unrelated.

/override ci/prow/e2e-agnostic

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

wking · 2021-06-15T16:13:30Z

pods should successfully create sandboxes by other and etcdHighNumberOfLeaderChanges are unrelated.

/override ci/prow/e2e-agnostic-upgrade

openshift-ci · 2021-06-15T16:13:40Z

@wking: Overrode contexts on behalf of wking: ci/prow/e2e-agnostic-upgrade

Details

In response to this:

pods should successfully create sandboxes by other and etcdHighNumberOfLeaderChanges are unrelated.

/override ci/prow/e2e-agnostic-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

wking · 2021-06-15T18:42:22Z

gather-audit-logs flake is unrelated:

/override ci/prow/e2e-agnostic-operator

openshift-ci · 2021-06-15T18:42:32Z

@wking: Overrode contexts on behalf of wking: ci/prow/e2e-agnostic-operator

Details

In response to this:

gather-audit-logs flake is unrelated:

/override ci/prow/e2e-agnostic-operator

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

wking · 2021-06-15T23:44:07Z

etcdHighNumberOfLeaderChanges and API-server connectivity are unrelated.

/override ci/prow/e2e-agnostic-upgrade

openshift-ci · 2021-06-15T23:44:17Z

@wking: Overrode contexts on behalf of wking: ci/prow/e2e-agnostic-upgrade

Details

In response to this:

etcdHighNumberOfLeaderChanges and API-server connectivity are unrelated.

/override ci/prow/e2e-agnostic-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

wking · 2021-06-15T23:54:38Z

/override ci/prow/e2e-agnostic

We've passed that one before, and this change is unrelated to other recent master changes.

openshift-ci · 2021-06-15T23:54:48Z

@wking: Overrode contexts on behalf of wking: ci/prow/e2e-agnostic

Details

In response to this:

/override ci/prow/e2e-agnostic

We've passed that one before, and this change is unrelated to other recent master changes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot requested review from crawford and smarterclayton April 13, 2021 23:37

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 13, 2021

LalatenduMohanty suggested changes Apr 14, 2021

View reviewed changes

install/0000_90_cluster-version-operator_02_servicemonitor.yaml Outdated Show resolved Hide resolved

dofinn reviewed Apr 14, 2021

View reviewed changes

wking force-pushed the modernize-alerts branch from ec60c94 to 86f8995 Compare April 20, 2021 19:16

LalatenduMohanty approved these changes Apr 20, 2021

View reviewed changes

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 20, 2021

openshift-ci-robot assigned LalatenduMohanty Apr 20, 2021

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 20, 2021

openshift-ci-robot assigned dofinn Apr 20, 2021

wking mentioned this pull request Apr 29, 2021

Bug 1834551: pkg/cvo/metrics: Ignore Degraded for cluster_operator_up #550

Merged

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 4, 2021

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 4, 2021

openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 11, 2021

wking force-pushed the modernize-alerts branch from 86f8995 to bb5119d Compare June 14, 2021 18:15

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 14, 2021

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 14, 2021

LalatenduMohanty approved these changes Jun 14, 2021

View reviewed changes

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 14, 2021

wking removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 15, 2021

openshift-merge-robot merged commit 4269c42 into openshift:master Jun 15, 2021

wking deleted the modernize-alerts branch June 15, 2021 23:58

wking mentioned this pull request Oct 19, 2021

Send alert when MCO can't safely apply updated Kubelet CA on nodes in paused pool openshift/machine-config-operator#2802

Merged

wking mentioned this pull request May 30, 2024

OCPBUGS-33896: upgrade status: polish alert insights openshift/oc#1787

Merged

install/0000_90_cluster-version-operator_02_servicemonitor: Alert summary/descriptions #547

install/0000_90_cluster-version-operator_02_servicemonitor: Alert summary/descriptions #547

Uh oh!

Conversation

wking commented Apr 13, 2021

Uh oh!

wking commented Apr 14, 2021

Uh oh!

Uh oh!

dofinn Apr 14, 2021

Choose a reason for hiding this comment

Uh oh!

wking Apr 20, 2021

Choose a reason for hiding this comment

Uh oh!

LalatenduMohanty left a comment

Choose a reason for hiding this comment

Uh oh!

dofinn commented Apr 20, 2021

Uh oh!

openshift-ci-robot commented Apr 20, 2021

Uh oh!

LalatenduMohanty commented May 4, 2021

Uh oh!

LalatenduMohanty commented May 4, 2021

Uh oh!

wking commented May 4, 2021

Uh oh!

openshift-ci bot commented May 11, 2021

Uh oh!

wking commented Jun 14, 2021

Uh oh!

LalatenduMohanty left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci bot commented Jun 14, 2021

Uh oh!

wking commented Jun 15, 2021

Uh oh!

openshift-ci bot commented Jun 15, 2021

Uh oh!

wking commented Jun 15, 2021

Uh oh!

openshift-ci bot commented Jun 15, 2021

Uh oh!

wking commented Jun 15, 2021

Uh oh!

openshift-ci bot commented Jun 15, 2021

Uh oh!

wking commented Jun 15, 2021

Uh oh!

openshift-ci bot commented Jun 15, 2021

Uh oh!

wking commented Jun 15, 2021

Uh oh!

openshift-ci bot commented Jun 15, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants