pkg/cvo: allow sync task for a manifest to be requeued on special failures #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
approved
abhinavdahiya
force-pushed
the
skip_to_end
branch
from
5e6094f to
68b996e
Compare
Contributor
smarterclayton
left a comment
smarterclayton
left a comment
There was a problem hiding this comment.
two comments lgtm otherwise
…lures Adding `v1.cluster-version-operator.operators.openshift.io/requeue-on-error` annotation with list of supported errros to a manifests will allow cvo to requeue the task once if it encounters one of the specified errors. For now only `NoMatch` is supported. Also added sync tests
abhinavdahiya
force-pushed
the
skip_to_end
branch
from
68b996e to
31e4d29
Compare
Contributor
Author
|
/retest |
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, smarterclayton The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding
v1.cluster-version-operator.operators.io/RequeueOnErrorannotation withlist of supported errros to a manifests will allow cvo to requeue the task once if it encounters one of the specified errors.
For now only
IsNoMatchis supported.Also added sync tests
/cc @smarterclayton