Skip to content

Enable gosimple #602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Jun 23, 2021
Merged

Enable gosimple #602

openshift-merge-robot merged 1 commit into from
Jun 23, 2021

Conversation

@arjunrn
Copy link
Contributor

@arjunrn arjunrn commented Jun 14, 2021 •
edited
Loading

Depends on #598 and #597

This linter looks for common non-idiomatic patterns in code which can be simplified.

Result from linter:

pkg/cvo/sync_worker_test.go:88:5       gosimple  S1000: should use a simple channel send/receive instead of `select` with a single case
pkg/cvo/sync_worker_test.go:102:5      gosimple  S1000: should use a simple channel send/receive instead of `select` with a single case
pkg/cvo/sync_worker_test.go:141:4      gosimple  S1000: should use a simple channel send/receive instead of `select` with a single case
pkg/cvo/cvo_scenarios_test.go:418:12   gosimple  S1039: unnecessary use of fmt.Sprintf
pkg/cvo/cvo_scenarios_test.go:1081:12  gosimple  S1039: unnecessary use of fmt.Sprintf
pkg/cvo/cvo_scenarios_test.go:1332:12  gosimple  S1039: unnecessary use of fmt.Sprintf
pkg/cvo/sync_worker.go:1004:2          gosimple  S1011: should replace loop with `nested = append(nested, errs...)`

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 14, 2021
@arjunrn arjunrn mentioned this pull request Jun 14, 2021
Merged
arjunrn
arjunrn commented Jun 17, 2021
View reviewed changes
pkg/cvo/sync_worker.go
return nil
}

nested := make([]error, 0, len(errs))
Copy link
Contributor Author

@arjunrn arjunrn Jun 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This error slice was never used.

arjunrn
arjunrn commented Jun 17, 2021
View reviewed changes
pkg/cvo/sync_worker_test.go
w.Report(tt.next)
close(w.w.report)
if tt.want {
select {
Copy link
Contributor Author

@arjunrn arjunrn Jun 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there is single channel to read from then a select-case to read is not required.

@arjunrn
Copy link
Contributor Author

arjunrn commented Jun 17, 2021

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 17, 2021
@arjunrn
Copy link
Contributor Author

arjunrn commented Jun 18, 2021

/assign @LalatenduMohanty

@LalatenduMohanty
Copy link
Member

LalatenduMohanty commented Jun 21, 2021

/override ci/prow/e2e-agnostic-upgrade

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 21, 2021

@LalatenduMohanty: Overrode contexts on behalf of LalatenduMohanty: ci/prow/e2e-agnostic-upgrade

Details

In response to this:

/override ci/prow/e2e-agnostic-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vrutkovs
Copy link

vrutkovs commented Jun 22, 2021

/retest

LalatenduMohanty
LalatenduMohanty approved these changes Jun 23, 2021
View reviewed changes
Copy link
Member

@LalatenduMohanty LalatenduMohanty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 23, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 23, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: arjunrn, LalatenduMohanty

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 23, 2021
@LalatenduMohanty
Copy link
Member

LalatenduMohanty commented Jun 23, 2021

/override ci/prow/e2e-agnostic-upgrade

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 23, 2021

@LalatenduMohanty: Overrode contexts on behalf of LalatenduMohanty: ci/prow/e2e-agnostic-upgrade

Details

In response to this:

/override ci/prow/e2e-agnostic-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 1cbdec5 into openshift:master Jun 23, 2021
@arjunrn arjunrn deleted the enable-gosimple branch June 23, 2021 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@crawford crawford Awaiting requested review from crawford

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

1 more reviewer

@LalatenduMohanty LalatenduMohanty LalatenduMohanty approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@LalatenduMohanty LalatenduMohanty

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@arjunrn @LalatenduMohanty @vrutkovs @openshift-merge-robot