Skip to content

Conversation

@wking
Copy link
Member

@wking wking commented Jun 14, 2021

This reverts commit 9bde7bb, #585.

It was a temporary workaround in 4.8 to bridge a gap between Kube-API-server and Kube-controller-manager during 4.7 -> 4.8 updates. Once the cluster has reconciled 4.8, we will no longer need the crutch. And 4.8 has now forked off master, so we can revert now, and that revert will go out in 4.9.

…lume injection"

This reverts commit 9bde7bb, openshift#585.

It was a temporary workaround in 4.8 to bridge a gap between
Kube-API-server and Kube-controller-manager during 4.7 -> 4.8
updates. Once the cluster has reconciled 4.8, we will no longer need
the crutch.  And 4.8 has now forked off master, so we can revert now,
and that revert will go out in 4.9.
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 14, 2021
Copy link
Member

@LalatenduMohanty LalatenduMohanty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 14, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LalatenduMohanty, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [LalatenduMohanty,wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 14, 2021
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@wking
Copy link
Member Author

wking commented Jun 15, 2021

update job's etcdHighNumberOfLeaderChanges, pods should successfully create sandboxes by other, and API connectivity issues are all unrelated.

/override ci/prow/e2e-agnostic-upgrade

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 15, 2021

@wking: Overrode contexts on behalf of wking: ci/prow/e2e-agnostic-upgrade

Details

In response to this:

update job's etcdHighNumberOfLeaderChanges, pods should successfully create sandboxes by other, and API connectivity issues are all unrelated.

/override ci/prow/e2e-agnostic-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wking
Copy link
Member Author

wking commented Jun 15, 2021

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 15, 2021

@wking: Overrode contexts on behalf of wking: ci/prow/unit

Details

In response to this:

TestCVO_UpgradeUnverifiedPayloadRetrieveOnce race is unrelated.

/override ci/prow/unit

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wking
Copy link
Member Author

wking commented Jun 15, 2021

API-server connectivity is unrelated.

/override ci/prow/e2e-agnostic-upgrade

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 15, 2021

@wking: Overrode contexts on behalf of wking: ci/prow/e2e-agnostic-upgrade

Details

In response to this:

API-server connectivity is unrelated.

/override ci/prow/e2e-agnostic-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wking
Copy link
Member Author

wking commented Jun 15, 2021

Orthogonal to the other recent master changes; no need to wait through a bunch of retests.

@wking wking merged commit c27e7e4 into openshift:master Jun 15, 2021
@wking wking deleted the revert-automountServiceAccountToken branch June 15, 2021 17:08
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 15, 2021

@wking: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/unit 879386d link /test unit
ci/prow/e2e-agnostic-upgrade 879386d link /test e2e-agnostic-upgrade

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

lance5890 added a commit to lance5890/cluster-version-operator that referenced this pull request Aug 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants