Bug 1978749: pkg/cvo: Respect noProxy

[wking]

Since 4.2's ea5e3bc (#219), the CVO has been consuming httpsProxy, but not httpProxy or noProxy. This pull request fixes that. I'm handing off the logic that mixes those three together to pick the proxy URI to the httpproxy library, which is also what the Go standard library uses for this purpose.

[openshift-ci]

@wking: This pull request references Bugzilla bug 1978749, which is invalid:

• expected the bug to target the "4.9.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1978749: pkg/cvo: Respect noProxy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[wking]

/bugzilla refresh

[openshift-ci]

@wking: This pull request references Bugzilla bug 1978749, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.9.0) matches configured target release for branch (4.9.0)
• bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @jianlinliu

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jottofar]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jottofar, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [jottofar,wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@wking: All pull requests linked via external trackers have merged:

• openshift/cluster-version-operator#622

Bugzilla bug 1978749 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1978749: pkg/cvo: Respect noProxy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[wking]

/cherrypick release-4.8

[openshift-cherrypick-robot]

@wking: #622 failed to apply on top of branch "release-4.8":

Applying: pkg/cvo: Respect noProxy
Using index info to reconstruct a base tree...
M	pkg/cincinnati/cincinnati.go
M	pkg/cvo/cvo.go
M	pkg/cvo/egress.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/cvo/egress.go
CONFLICT (content): Merge conflict in pkg/cvo/egress.go
Auto-merging pkg/cvo/cvo.go
Auto-merging pkg/cincinnati/cincinnati.go
CONFLICT (content): Merge conflict in pkg/cincinnati/cincinnati.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 pkg/cvo: Respect noProxy
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Details

In response to this:

/cherrypick release-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.