Bug 1985802: Updating the lease, renew, retry duration #634
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
openshift-ci
bot
added
the
approved
LalatenduMohanty
changed the title
Member
Author
|
/bugzilla refresh |
Contributor
|
@LalatenduMohanty: No Bugzilla bug is referenced in the title of this pull request. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
LalatenduMohanty
changed the title
Contributor
|
@LalatenduMohanty: This pull request references Bugzilla bug 1985802, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
bugzilla/severity-high
Member
|
/uncc |
jottofar
reviewed
Jul 30, 2021
|
/lgtm [Pre-Merge QA Testing]
Best Regards. |
openshift-ci
bot
added
the
qe-approved
Contributor
|
@pamoedom: This pull request references Bugzilla bug 1985802, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
wking
reviewed
Aug 3, 2021
LalatenduMohanty
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
Member
Author
|
/retest |
LalatenduMohanty
force-pushed
the
BZ_1985802
branch
from
9880cec to
7328f52
Compare
LalatenduMohanty
force-pushed
the
BZ_1985802
branch
from
7328f52 to
bd0ae2c
Compare
LalatenduMohanty
changed the title
For both single node clusters (SNO) and non-SNO clusters leader election need to tolerate 60s worth of disruption [2]. The default in library-go has been upgaded to handle this case in 4.9 [1]. In essence, the kube-apiserver downtime tolerance is floor(renewDeadline/retryPeriod)*retryPeriod-retryPeriod. Recommended defaults are LeaseDuration=137s RenewDealine=107s RetryPeriod=26s. These are the configurable values in k8s.io/client-go based leases and controller-runtime exposes them. This gives us clock skew tolerance == 30s kube-apiserver downtime tolerance == 78s worst non-graceful lease reacquisition == 163s worst graceful lease reacquisition == 26s For learning more about client side leader election config refer to [3] [1] https://github.com/openshift/library-go/blob/4b9033d00d37b88393f837a88ff541a56fd13621/pkg/config/leaderelection/leaderelection.go#L84 [2] https://github.com/openshift/enhancements/blob/c91e5ae66ed590405fb205433131c6a75f05610d/CONVENTIONS.md#high-availability [3] https://pkg.go.dev/k8s.io/client-go/tools/leaderelection#LeaderElectionConfig Signed-off-by: Lalatendu Mohanty <[email protected]>
LalatenduMohanty
force-pushed
the
BZ_1985802
branch
from
bd0ae2c to
d39b5c5
Compare
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: LalatenduMohanty, pamoedom, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
7 similar comments
Contributor
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
Contributor
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
Contributor
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
Contributor
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
Contributor
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
Contributor
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
Contributor
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
Contributor
|
@LalatenduMohanty: All pull requests linked via external trackers have merged: Bugzilla bug 1985802 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per [1]
[1] https://github.com/openshift/library-go/blob/4b9033d00d37b88393f837a88ff541a56fd13621/pkg/config/leaderelection/leaderelection.go#L84
Signed-off-by: Lalatendu Mohanty [email protected]