Bug 2007674: pkg/cvo/egress: Load HTTPS proxy from Proxy status #664

openshift-cherrypick-robot · 2021-09-24T14:35:20Z

This is an automated cherry-pick of #627

/assign palonsoro

Since 4.2's ea5e3bc (Add http transport for cincinnati to enable proxy, 2019-07-16, openshift#219), the CVO has been loading proxy config from the spec property. We should be loading from status instead, so we benefit from the network operator's validation. Risk is small, because unlike some other in-cluster components, the CVO is unlikely to break things if it is temporarily consuming a broken proxy configuration. This is similar to c9fab43 (pkg/cvo: Fetch proxy CA certs from openshift-config-managed/trusted-ca-bundle, 2020-01-31, openshift#311), where we moved our trusted CA source from the user-configured ConfigMap to the network-operator-validated ConfigMap.

openshift-ci · 2021-09-24T14:35:26Z

@openshift-cherrypick-robot: An error was encountered cloning bug for cherrypick for bug 1980411 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message.


code 53: Bugzilla_api_key is not a valid parameter for the Bugzilla::Bug::create function.

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

Details

In response to this:

[release-4.7] Bug 1980411: [release-4.8] pkg/cvo/egress: Load HTTPS proxy from Proxy status

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

palonsoro · 2021-09-24T14:36:55Z

/title [release-4.7] Bug 2007674: pkg/cvo/egress: Load HTTPS proxy from Proxy status

palonsoro · 2021-09-24T14:38:24Z

/retitle [release-4.7] Bug 2007674: pkg/cvo/egress: Load HTTPS proxy from Proxy status

openshift-ci · 2021-09-24T14:38:29Z

@openshift-cherrypick-robot: This pull request references Bugzilla bug 2007674, which is invalid:

expected dependent Bugzilla bug 1978774 to target a release in 4.8.0, 4.8.z, but it targets "4.9.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

[release-4.7] Bug 2007674: pkg/cvo/egress: Load HTTPS proxy from Proxy status

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

palonsoro · 2021-09-24T14:38:37Z

/bugzilla refresh

openshift-ci · 2021-09-24T14:38:42Z

@palonsoro: This pull request references Bugzilla bug 2007674, which is invalid:

expected dependent Bugzilla bug 1978774 to target a release in 4.8.0, 4.8.z, but it targets "4.9.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

palonsoro · 2021-09-24T14:40:13Z

/bugzilla refresh

openshift-ci · 2021-09-24T14:40:23Z

@palonsoro: This pull request references Bugzilla bug 2007674, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.7.z) matches configured target release for branch (4.7.z)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1980411 is in the state CLOSED (ERRATA), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
dependent Bugzilla bug 1980411 targets the "4.8.z" release, which is one of the valid target releases: 4.8.0, 4.8.z
bug has dependents

Requesting review from QA contact:
/cc @jianlinliu

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

wking

/retitle Bug 2007674: pkg/cvo/egress: Load HTTPS proxy from Proxy status

No need to track the target branch in the PR subject. GitHub tracks it as structured information for all PRs, and it clutters the oc adm release info --changes-from ... diffs.

Clean pick, and it's had some cook-time in 4.8, so:

/lgtm

openshift-ci · 2021-09-24T19:53:44Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2021-09-24T20:04:42Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-09-24T21:05:12Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

dhellmann · 2021-09-27T17:44:11Z

[patch-manager] 🚀 Approved for z-stream by score: 0.10

picked

openshift-ci · 2021-09-27T17:45:02Z

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

openshift/cluster-version-operator#664

Bugzilla bug 2007674 has been moved to the MODIFIED state.

Details

In response to this:

Bug 2007674: pkg/cvo/egress: Load HTTPS proxy from Proxy status

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci bot assigned palonsoro Sep 24, 2021

openshift-cherrypick-robot mentioned this pull request Sep 24, 2021

Bug 1980411: [release-4.8] pkg/cvo/egress: Load HTTPS proxy from Proxy status #627

Merged

openshift-ci bot requested review from jottofar and smarterclayton September 24, 2021 14:35

openshift-ci bot changed the title ~~[release-4.7] Bug 1980411: [release-4.8] pkg/cvo/egress: Load HTTPS proxy from Proxy status~~ [release-4.7] Bug 2007674: pkg/cvo/egress: Load HTTPS proxy from Proxy status Sep 24, 2021

openshift-ci bot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Sep 24, 2021

openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Sep 24, 2021

openshift-ci bot requested a review from jianlinliu September 24, 2021 14:40

wking approved these changes Sep 24, 2021

View reviewed changes

openshift-ci bot changed the title ~~[release-4.7] Bug 2007674: pkg/cvo/egress: Load HTTPS proxy from Proxy status~~ Bug 2007674: pkg/cvo/egress: Load HTTPS proxy from Proxy status Sep 24, 2021

openshift-ci bot assigned wking Sep 24, 2021

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 24, 2021

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 24, 2021

dhellmann added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Sep 27, 2021

openshift-merge-robot merged commit 4e7c701 into openshift:release-4.7 Sep 27, 2021

Bug 2007674: pkg/cvo/egress: Load HTTPS proxy from Proxy status #664

Bug 2007674: pkg/cvo/egress: Load HTTPS proxy from Proxy status #664

Uh oh!

Conversation

openshift-cherrypick-robot commented Sep 24, 2021

Uh oh!

openshift-ci bot commented Sep 24, 2021

Uh oh!

palonsoro commented Sep 24, 2021

Uh oh!

palonsoro commented Sep 24, 2021

Uh oh!

openshift-ci bot commented Sep 24, 2021

Uh oh!

palonsoro commented Sep 24, 2021

Uh oh!

openshift-ci bot commented Sep 24, 2021

Uh oh!

palonsoro commented Sep 24, 2021

Uh oh!

openshift-ci bot commented Sep 24, 2021

Uh oh!

wking left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci bot commented Sep 24, 2021

Uh oh!

openshift-bot commented Sep 24, 2021

Uh oh!

openshift-bot commented Sep 24, 2021

Uh oh!

dhellmann commented Sep 27, 2021

Uh oh!

openshift-ci bot commented Sep 27, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants