Bug 2026560: lib/resourcemerge/core: Merge volumeMounts by mountPath #703
Conversation
We had been merging by name since ensureVolumeMounts landed in 83faa6e (lib/resourcemerge/core: Remove unrecognized volumes and mounts, 2021-09-14, openshift#654). But as pointed out in [1], a single volume may be mounted at multiple paths. With this commit, I'm pivoting to merge by mountPath, which is the patchMergeKey [2] (and it makes sense that you wouldn't have multiple volumes mounted at the same path). [1]: https://bugzilla.redhat.com/show_bug.cgi?id=2026560 [2]: https://github.com/kubernetes/api/blob/1d6faf224f146dd002553f55cd9fcaaaa0dc00cb/core/v1/types.go#L2367
openshift-ci
bot
added
bugzilla/severity-medium
|
@wking: This pull request references Bugzilla bug 2026560, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
requested review from
LalatenduMohanty,
jianlinliu and
vrutkovs
openshift-ci
bot
added
the
approved
|
/retest Holding off cherry-picks until 4.11 branches |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vrutkovs, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
not related to this PR |
|
@vrutkovs: Overrode contexts on behalf of vrutkovs: ci/prow/e2e-agnostic-upgrade DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
@wking: All pull requests linked via external trackers have merged: Bugzilla bug 2026560 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherrypick release-4.9 |
|
@wking: new pull request created: #715 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
5 participants
We had been merging by name since
ensureVolumeMountslanded in 83faa6e (#654). But as pointed out in rhbz#2026560, a single volume may be mounted at multiple paths. With this commit, I'm pivoting to merge bymountPath, which is thepatchMergeKey(and it makes sense that you wouldn't have multiple volumes mounted at the same path).