Bug 2070854: syncWorkerStatus: Avoid saving stale status values

[jottofar]

which can occur since the splitting of payload load and apply to be called in separate goroutines #683. Each thread will now call it's own update status function that only sets status values it manages.

[openshift-ci]

@jottofar: This pull request references Bugzilla bug 2070854, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.11.0) matches configured target release for branch (4.11.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @shellyyang1989

Details

In response to this:

Bug 2070854: statusWrapper: do not overwrite capabilities status

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jottofar]

/test e2e-agnostic-upgrade

[wking]

Seems unrelated:

: operator conditions node-tuning | 0s
-- | --
{Operator progressing (ProfileProgressing): Waiting for 1/6 Profiles to be applied  Operator progressing (ProfileProgressing): Waiting for 1/6 Profiles to be applied}

But also means we have no update coverage at all. I'm pretty confident that this change did not break updates though, so:

/override ci/prow/e2e-agnostic-upgrade

[openshift-ci]

@wking: Overrode contexts on behalf of wking: ci/prow/e2e-agnostic-upgrade

Details

In response to this:

Seems unrelated:

: operator conditions node-tuning | 0s
-- | --
{Operator progressing (ProfileProgressing): Waiting for 1/6 Profiles to be applied  Operator progressing (ProfileProgressing): Waiting for 1/6 Profiles to be applied}

But also means we have no update coverage at all. I'm pretty confident that this change did not break updates though, so:

/override ci/prow/e2e-agnostic-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jottofar]

/retitle Bug 2070854: syncWorkerStatus: Avoid saving stale status values

[openshift-ci]

@jottofar: This pull request references Bugzilla bug 2070854, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.11.0) matches configured target release for branch (4.11.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @shellyyang1989

Details

In response to this:

Bug 2070854: syncWorkerStatus: Avoid saving stale status values

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[wking]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jottofar, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [jottofar,wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jottofar]

/test e2e-agnostic-upgrade

[openshift-bot]

/retest-required

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest-required

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest-required

Please review the full test history for this PR and help us cut down flakes.

[openshift-ci]

@jottofar: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci]

@jottofar: All pull requests linked via external trackers have merged:

• openshift/cluster-version-operator#759

Bugzilla bug 2070854 has been moved to the MODIFIED state.

Details

In response to this:

Bug 2070854: syncWorkerStatus: Avoid saving stale status values

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.