restart CVO when credentials rotate causing serviceaccount files to change #78
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
size/L
|
Looks fine to me. When I add graceful shutdown we’ll have to change the reaction, but that’s ok |
On an upgrade the CVO is always restarted but we don't release our lease, which causes the new CVO pod to have to wait. We should release our lease on exit. Kube 1.14 (pr 71490) contains a new flag on leader lease that allows the caller to step down gracefully. Because backporting that change to client-go is complicated, we instead emulate the logic. When that code is available we can simplify down.
abhinavdahiya
force-pushed
the
restart_on_change
branch
from
6dacdb3 to
cf20f7d
Compare
openshift-ci-robot
added
size/XXL
|
/cc @smarterclayton rebase on #87 to use the graceful shutdown from #87 |
abhinavdahiya
force-pushed
the
restart_on_change
branch
from
cf20f7d to
8889c67
Compare
|
@abhinavdahiya: PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
needs-rebase
|
@abhinavdahiya: The following test failed for commit 8889c67, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
I didn't realize we didn't come back to this - I assume it's still needed |
|
closing because this is too old now. /close |
|
@abhinavdahiya: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
3 participants
/cc @deads2k @smarterclayton