-
Notifications
You must be signed in to change notification settings - Fork 213
pkg/cvo/status.go: sort implicitly enabled caps #814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Instead of reducing to a single entry, can we sort here so we present a stable, sorted string to users? |
|
/retitle pkg/cvo/status.go: sort implicitly enabled caps |
in condition message to avoid test failures caused by bg sync timing that affects the order of the implicitly enabled capabilities.
|
/test e2e-agnostic-upgrade |
wking
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jottofar, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
/test e2e-agnostic-upgrade |
|
@wking: Overrode contexts on behalf of wking: ci/prow/e2e-agnostic-upgrade DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Image registry remains available using new connections but could not possibly be related to this sort change /override ci/prow/e2e-agnostic-upgrade |
|
@jottofar: Overrode contexts on behalf of jottofar: ci/prow/e2e-agnostic-upgrade DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@jottofar: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
in condition message to avoid test failures caused by bg
sync timing that affects the order of the implicitly
enabled capabilities.