Skip to content

Conversation

@jottofar
Copy link
Contributor

@jottofar jottofar commented Aug 3, 2022

in condition message to avoid test failures caused by bg
sync timing that affects the order of the implicitly
enabled capabilities.

@openshift-ci openshift-ci bot requested review from vrutkovs and wking August 3, 2022 21:12
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 3, 2022
@wking
Copy link
Member

wking commented Aug 4, 2022

This avoids test failures caused by by sync timing that affects the order of the implictly enabled capabilities.

Instead of reducing to a single entry, can we sort here so we present a stable, sorted string to users?

@jottofar
Copy link
Contributor Author

jottofar commented Aug 4, 2022

/retitle pkg/cvo/status.go: sort implicitly enabled caps

@openshift-ci openshift-ci bot changed the title pkg/cvo/cvo_scenarios_test.go: simplify TestCVO_InitImplicitlyEnabled… pkg/cvo/status.go: sort implicitly enabled caps Aug 4, 2022
in condition message to avoid test failures caused by bg
sync timing that affects the order of the implicitly
enabled capabilities.
@jottofar
Copy link
Contributor Author

jottofar commented Aug 4, 2022

/test e2e-agnostic-upgrade

Copy link
Member

@wking wking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 4, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 4, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jottofar, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 2 against base HEAD 9d57cfc and 8 for PR HEAD acf9552 in total

@jottofar
Copy link
Contributor Author

jottofar commented Aug 5, 2022

/retest

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 1 against base HEAD 9d57cfc and 7 for PR HEAD acf9552 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 9d57cfc and 6 for PR HEAD acf9552 in total

@jottofar
Copy link
Contributor Author

jottofar commented Aug 5, 2022

/test e2e-agnostic-upgrade

@wking
Copy link
Member

wking commented Aug 5, 2022

Image registry remains available using new connections is failing often, but could not possibly be related to this sort change :p.

/override ci/prow/e2e-agnostic-upgrade

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 5, 2022

@wking: Overrode contexts on behalf of wking: ci/prow/e2e-agnostic-upgrade

Details

In response to this:

Image registry remains available using new connections is failing often, but could not possibly be related to this sort change :p.

/override ci/prow/e2e-agnostic-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 2 against base HEAD 0f8c533 and 5 for PR HEAD acf9552 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 1 against base HEAD 0f8c533 and 4 for PR HEAD acf9552 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 0f8c533 and 3 for PR HEAD acf9552 in total

@jottofar
Copy link
Contributor Author

jottofar commented Aug 8, 2022

Image registry remains available using new connections but could not possibly be related to this sort change

/override ci/prow/e2e-agnostic-upgrade

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 8, 2022

@jottofar: Overrode contexts on behalf of jottofar: ci/prow/e2e-agnostic-upgrade

Details

In response to this:

Image registry remains available using new connections but could not possibly be related to this sort change

/override ci/prow/e2e-agnostic-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 8, 2022

@jottofar: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 02838c7 into openshift:master Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants