pkg/cincinnati: add required parameters to requests

[lucab]

This adds three mandatory parameters to cincinnati requests, as per
cincinnati-openshift specs.

Ref: https://github.com/openshift/cincinnati/blob/06c9ce64367b55f453295b2765a9aab61791dc76/docs/design/openshift.md#request

[lucab]

/hold
/cc @crawford

[lucab]

/test e2e-aws

[crawford]

/approve

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: crawford, lucab

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [crawford]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[smarterclayton]

Can you guys add a Cincinnati integration test to pkg/start/start_integration_test.go (moved in #87) with a shim Cincinnati endpoint that verifies the behavior? We have functional tests in cvo_test but an extra higher level test will be good. Doesn't have to be here, just was looking at the bug and realized it would be a good candidate.

[lucab]

/test integration

[smarterclayton]

/retest

[lucab]

/test integration

[steveej]

@smarterclayton is this blocked on the additional test you've asked for?

[lucab]

This was on hold due to the freeze being in place at the time, it should be fine now. My understanding is that this is not blocked on the suggested integration test, but I can add it if required (I only briefly skimmed through the existing one).

/hold cancel
/test integration

[smarterclayton]

I would like a test showing the url being constructed in cvo_test.go

[smarterclayton]

Or scenarios test or thenintegrstion test (the integration test is probably the best place because we can run a local server and report

[openshift-merge-robot]

/retest

[openshift-merge-robot]

/retest

[lucab]

Superseded by #121.