[release-4.12] OCPBUGS-5879: Set upgradeability check throttling period to 2m #884

openshift-cherrypick-robot · 2023-01-16T14:24:09Z

This is an automated cherry-pick of #882

/assign petr-muller

Previously, the throttling reused the `minimumUpdateCheckInterval` value which is derived from the full CVO minimum sync period. This value is set between 2m and 4m at CVO startup. This period is unecessarily long and bad for UX, things happen with a delay and our own testcase expects upgradeability to be propagated in 3 minutes at worst. Hardcode the throttling to 2m (lower bound of previous behavior) to prevent flapping on flurries but allow changes to propagate deterministically faster. We will still get a bit of non-determinisim from sync periods and requeueing, so this change should not cause any periodic API-hammering.

Refactor the code that handles throttling upgradeability checks. Create a new method that computes the duration for which the existing `Upgradeable` status is considered recent enough to not be synced, and simply pass this duration to the `RecentlyChanged` method. The new method is now unit tested, too. Upgradeable-related intervals are now uncoupled to unrelated sync intervals and are grouped in a new struct.

openshift-ci-robot · 2023-01-16T14:24:16Z

@openshift-cherrypick-robot: Jira Issue OCPBUGS-5505 has been cloned as Jira Issue OCPBUGS-5879. Retitling PR to link against new bug.
/retitle [release-4.12] OCPBUGS-5879: Set upgradeability check throttling period to 2m

Details

In response to this:

This is an automated cherry-pick of #882

/assign petr-muller

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2023-01-16T14:24:31Z

@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

[release-4.12] OCPBUGS-5879: Set upgradeability check throttling period to 2m

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-01-16T14:24:35Z

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-5879, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.12.0) matches configured target version for branch (4.12.0)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
dependent bug Jira Issue OCPBUGS-5505 is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
dependent Jira Issue OCPBUGS-5505 targets the "4.13.0" version, which is one of the valid target versions: 4.13.0
bug has dependents

Requesting review from QA contact:
/cc @jiajliu

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #882

/assign petr-muller

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

petr-muller · 2023-01-16T19:22:18Z

alert OperatorHubSourceError fired for 60 seconds with labels: {container="catalog-operator", endpoint="https-metrics", exported_namespace="openshift-marketplace", instance="10.130.0.29:8443", job="catalog-operator-metrics", name="community-operators", namespace="openshift-operator-lifecycle-manager", pod="catalog-operator-854b5b8d75-tx7ck", service="catalog-operator-metrics", severity="warning"}

in the upgrade test -> unrelated to CVO

unit tests failed on TestCVO_UpgradeFailedPayloadLoadWithCapsChanges flake that was only fixed later

/retest

petr-muller · 2023-01-17T09:10:06Z

/test unit

openshift-ci · 2023-01-17T09:35:18Z

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

LalatenduMohanty · 2023-01-17T16:39:57Z

/label backport-risk-assessed

LalatenduMohanty

/lgtm

openshift-ci · 2023-01-17T16:41:03Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LalatenduMohanty, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [LalatenduMohanty]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

petr-muller · 2023-01-17T17:22:59Z

/hold

We're still verifying the original fix

petr-muller · 2023-01-19T16:33:55Z

/hold cancel
/jira refresh

openshift-ci-robot · 2023-01-19T16:34:01Z

@petr-muller: This pull request references Jira Issue OCPBUGS-5879, which is valid.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.12.z) matches configured target version for branch (4.12.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
dependent bug Jira Issue OCPBUGS-5505 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
dependent Jira Issue OCPBUGS-5505 targets the "4.13.0" version, which is one of the valid target versions: 4.13.0
bug has dependents

Requesting review from QA contact:
/cc @evakhoni

Details

In response to this:

/hold cancel
/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jianlinliu · 2023-01-20T01:01:22Z

/label cherry-pick-approved

openshift-ci-robot · 2023-01-20T01:07:50Z

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

openshift/cluster-version-operator#884

Jira Issue OCPBUGS-5879 has been moved to the MODIFIED state.

Details

In response to this:

This is an automated cherry-pick of #882

/assign petr-muller

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

petr-muller added 2 commits January 16, 2023 14:24

openshift-cherrypick-robot mentioned this pull request Jan 16, 2023

OCPBUGS-5505: Set upgradeability check throttling period to 2m #882

Merged

openshift-cherrypick-robot assigned petr-muller Jan 16, 2023

openshift-ci bot changed the title ~~[release-4.12] OCPBUGS-5505: Set upgradeability check throttling period to 2m~~ [release-4.12] OCPBUGS-5879: Set upgradeability check throttling period to 2m Jan 16, 2023

openshift-ci bot requested review from LalatenduMohanty, jiajliu and wking January 16, 2023 14:24

openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jan 17, 2023

LalatenduMohanty approved these changes Jan 17, 2023

View reviewed changes

openshift-ci bot assigned LalatenduMohanty Jan 17, 2023

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 17, 2023

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 17, 2023

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 17, 2023

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 19, 2023

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 19, 2023

openshift-ci bot requested a review from evakhoni January 19, 2023 16:34

openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jan 20, 2023

openshift-merge-robot merged commit b24d60e into openshift:release-4.12 Jan 20, 2023

[release-4.12] OCPBUGS-5879: Set upgradeability check throttling period to 2m #884

[release-4.12] OCPBUGS-5879: Set upgradeability check throttling period to 2m #884

Uh oh!

Conversation

openshift-cherrypick-robot commented Jan 16, 2023

Uh oh!

openshift-ci-robot commented Jan 16, 2023

Uh oh!

openshift-ci bot commented Jan 16, 2023

Uh oh!

openshift-ci-robot commented Jan 16, 2023

Uh oh!

petr-muller commented Jan 16, 2023

Uh oh!

petr-muller commented Jan 17, 2023

Uh oh!

openshift-ci bot commented Jan 17, 2023

Uh oh!

LalatenduMohanty commented Jan 17, 2023

Uh oh!

LalatenduMohanty left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci bot commented Jan 17, 2023

Uh oh!

petr-muller commented Jan 17, 2023

Uh oh!

petr-muller commented Jan 19, 2023

Uh oh!

openshift-ci-robot commented Jan 19, 2023

Uh oh!

jianlinliu commented Jan 20, 2023

Uh oh!

openshift-ci-robot commented Jan 20, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants