Skip to content

Enhancement for adding a manifest annotation for object removal #419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Oct 21, 2020
Merged

Enhancement for adding a manifest annotation for object removal #419

openshift-merge-robot merged 1 commit into from
Oct 21, 2020

Conversation

@jottofar
Copy link
Contributor

@jottofar jottofar commented Aug 4, 2020

No description provided.

@jottofar
Copy link
Contributor Author

jottofar commented Aug 4, 2020

/assign @LalatenduMohanty @wking @sdodson @crawford

@jottofar
Copy link
Contributor Author

jottofar commented Aug 4, 2020

/unassign @LalatenduMohanty @wking @sdodson @crawford

wking
wking reviewed Aug 4, 2020
View reviewed changes
wking
wking reviewed Aug 4, 2020
View reviewed changes
wking
wking reviewed Aug 4, 2020
View reviewed changes
wking
wking reviewed Aug 4, 2020
View reviewed changes
wking
wking reviewed Aug 4, 2020
View reviewed changes
wking
wking reviewed Aug 4, 2020
View reviewed changes
wking
wking reviewed Aug 4, 2020
View reviewed changes
wking
wking reviewed Aug 4, 2020
View reviewed changes
wking
wking reviewed Aug 4, 2020
View reviewed changes
@aravindhp
Copy link
Contributor

aravindhp commented Aug 4, 2020

/uncc @aravindhp

@openshift-ci-robot openshift-ci-robot removed the request for review from aravindhp August 4, 2020 18:03
wking
wking reviewed Aug 4, 2020
View reviewed changes
LalatenduMohanty
LalatenduMohanty reviewed Aug 5, 2020
View reviewed changes
LalatenduMohanty
LalatenduMohanty reviewed Aug 5, 2020
View reviewed changes
michaelgugino
michaelgugino reviewed Aug 5, 2020
View reviewed changes
smarterclayton
smarterclayton reviewed Aug 5, 2020
View reviewed changes
@jottofar jottofar force-pushed the ota-222 branch 3 times, most recently from 9b4c108 to dc1d585 Compare August 12, 2020 22:02
LalatenduMohanty
LalatenduMohanty suggested changes Aug 18, 2020
View reviewed changes
LalatenduMohanty
LalatenduMohanty reviewed Aug 18, 2020
View reviewed changes
@LalatenduMohanty
Copy link
Member

LalatenduMohanty commented Aug 18, 2020

I have two questions (added as comments), other than that this PR looks good to me.

michaelgugino
michaelgugino suggested changes Aug 19, 2020
View reviewed changes
wking
wking reviewed Aug 21, 2020
View reviewed changes
wking
wking reviewed Sep 2, 2020
View reviewed changes
@jottofar jottofar force-pushed the ota-222 branch 2 times, most recently from ee102cc to fb15be7 Compare September 2, 2020 18:19
@deads2k
Copy link
Contributor

deads2k commented Oct 6, 2020

I'm happy with this. Thanks.

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 6, 2020
@jottofar
Copy link
Contributor Author

jottofar commented Oct 21, 2020

@sdodson @deads2k Can one of you apply the lgtm to this. Clayton delegated to "CVO team", ref: https://coreos.slack.com/archives/C011CSSPBLK/p1603295356186000?thread_ts=1599075155.040100&cid=C011CSSPBLK

@wking
Copy link
Member

wking commented Oct 21, 2020

/lgtm

Clayton is too busy to approve this, so we'll land it, implement it, and collect feedback on the choices in the enhancement before going live with 4.7.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 21, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 21, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, jottofar, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit d3d818f into openshift:master Oct 21, 2020
@jottofar jottofar mentioned this pull request Apr 28, 2021
Merged
@wking wking mentioned this pull request Oct 21, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deads2k deads2k deads2k left review comments

@russellb russellb Awaiting requested review from russellb

+4 more reviewers

@wking wking wking left review comments

@smarterclayton smarterclayton smarterclayton left review comments

@LalatenduMohanty LalatenduMohanty LalatenduMohanty requested changes

@michaelgugino michaelgugino michaelgugino requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

@wking wking

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.