Skip to content

Conversation

@dlom
Copy link
Contributor

@dlom dlom commented Nov 2, 2022

@openshift-ci openshift-ci bot requested review from 2uasimojo and suhanime November 2, 2022 17:40
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 2, 2022
@codecov
Copy link

codecov bot commented Nov 2, 2022

Codecov Report

Merging #1903 (1aace4e) into master (e25c14f) will decrease coverage by 0.01%.
The diff coverage is 66.66%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1903      +/-   ##
==========================================
- Coverage   42.13%   42.11%   -0.02%     
==========================================
  Files         366      366              
  Lines       33976    34501     +525     
==========================================
+ Hits        14315    14530     +215     
- Misses      18458    18759     +301     
- Partials     1203     1212       +9     
Impacted Files Coverage Δ
...g/controller/clustersync/clustersync_controller.go 75.34% <66.66%> (-0.44%) ⬇️
pkg/operator/assets/bindata.go 0.00% <0.00%> (ø)
pkg/operator/hive/configmap.go 0.00% <0.00%> (ø)
...roller/awsprivatelink/awsprivatelink_controller.go 68.32% <0.00%> (+1.89%) ⬆️
...ntroller/remoteingress/remoteingress_controller.go 75.65% <0.00%> (+2.85%) ⬆️
pkg/client/fake/overrideable_client.go 66.66% <0.00%> (+3.50%) ⬆️
pkg/controller/dnsendpoint/nameserverscraper.go 96.34% <0.00%> (+4.16%) ⬆️
pkg/awsclient/client.go 21.40% <0.00%> (+4.57%) ⬆️
...or/github.com/openshift/hive/apis/scheme/scheme.go 21.05% <0.00%> (+7.71%) ⬆️

Copy link
Member

@2uasimojo 2uasimojo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 2, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 2, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 2uasimojo, dlom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@2uasimojo
Copy link
Member

actually

/hold

cause we talked about you looking at the logs on OSD stage before/after. Unhold once you've gotten your "before" picture.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 2, 2022
@dlom
Copy link
Contributor Author

dlom commented Nov 9, 2022

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 9, 2022
@dlom
Copy link
Contributor Author

dlom commented Nov 9, 2022

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 10, 2022

@dlom: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 6568c20 into openshift:master Nov 10, 2022
dlom added a commit to dlom/hive that referenced this pull request Nov 15, 2022
This reverts commit 6568c20, reversing
changes made to 18e4e87.
abutcher added a commit that referenced this pull request Nov 15, 2022
Revert "Merge pull request #1903 from dlom/HIVE-2038"
dlom added a commit to dlom/hive that referenced this pull request Dec 1, 2022
dlom added a commit to dlom/hive that referenced this pull request Dec 1, 2022
dlom added a commit to dlom/hive that referenced this pull request Dec 1, 2022
jcho02 pushed a commit to jcho02/hive that referenced this pull request Jan 5, 2023
jcho02 pushed a commit to jcho02/hive that referenced this pull request Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants