API-1835: Scaffold event dispatcher by p0lyn0mial · Pull Request #7543 · openshift/hypershift

p0lyn0mial · 2026-01-19T12:51:30Z

requires #7477

// inputResourceDispatcher is a simple dispatcher that applies GVK scoped filters
// and forwards matching events.
//
// Each GVK has its own set of filters. Today these
// may include name/namespace checks, and in the future label selectors.
//
// Longer term, this dispatcher is expected to track which input resources are
// associated with which operator.

openshift-ci-robot · 2026-01-19T12:51:35Z

@p0lyn0mial: This pull request references API-1835 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.22.0" version, but no target version was set.

Details

In response to this:

requires #7477

// inputResourceDispatcher is a simple dispatcher that applies GVK scoped filters
// and forwards matching events.
//
// Each GVK has its own set of filters. Today these
// may include name/namespace checks, and in the future label selectors.
//
// Longer term, this dispatcher is expected to track which input resources are
// associated with which operator.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

coderabbitai · 2026-01-19T12:51:45Z

Walkthrough

Adds a new per-GVK input resource dispatcher for filtering and forwarding Kubernetes events, alongside comprehensive unit tests validating the dispatch logic across multiple filter scenarios.

Changes

Cohort / File(s)	Summary
Input Resource Dispatcher `control-plane-operator/controllers/openshiftmanager/input_resource_dispatcher.go`, `input_resource_dispatcher_test.go`	Implements event dispatcher with per-GVK filtering; provides Handle method for event forwarding based on filter matches and ResultChan method for event consumption. Includes unit tests covering dispatch behavior for matching/non-matching filters, absent filters, and multiple filter scenarios.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

✨ Finishing touches

📝 Generate docstrings

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

p0lyn0mial · 2026-01-19T12:51:48Z

/assign @benluddy @bertinatto @csrwng

openshift-ci-robot · 2026-01-19T12:52:45Z

@p0lyn0mial: This pull request references API-1835 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.22.0" version, but no target version was set.

Details

In response to this:

requires #7477

// inputResourceDispatcher is a simple dispatcher that applies GVK scoped filters
// and forwards matching events.
//
// Each GVK has its own set of filters. Today these
// may include name/namespace checks, and in the future label selectors.
//
// Longer term, this dispatcher is expected to track which input resources are
// associated with which operator.

please review feat(openshiftmanager-phase2): intro inputResourceDispatcher only

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

p0lyn0mial · 2026-01-19T13:30:14Z

control-plane-operator/controllers/openshiftmanager/input_resource_dispatcher.go

+
+func newInputResourceDispatcher(filters map[schema.GroupVersionKind][]inputResourceEventFilter) *inputResourceDispatcher {
+	return &inputResourceDispatcher{
+		eventsCh: make(chan event.GenericEvent, 10),


I think I will change it to an unbuffered channel.
(let's start simple)

csrwng · 2026-01-19T13:45:28Z

/approve

coderabbitai

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In
`@control-plane-operator/controllers/openshiftmanager/input_resource_initializer.go`:
- Around line 47-49: The discoverInputResources function currently always
returns a "not implemented" error which blocks manager startup; change its
implementation in the inputResourceInitializer type so it returns an empty map
and nil error (e.g. make(map[string]*libraryinputresources.InputResources), nil)
to unblock startup, or implement the actual discovery logic used by
Start()/SetupWithManager if you prefer; locate and update discoverInputResources
(and ensure any callers like Start() handle an empty map) so the manager can
start successfully.

coderabbitai · 2026-01-19T13:56:55Z

control-plane-operator/controllers/openshiftmanager/input_resource_initializer.go

+func (r *inputResourceInitializer) discoverInputResources() (map[string]*libraryinputresources.InputResources, error) {
+	return nil, fmt.Errorf("not implemented")
+}


⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

# Find registration/usage of the initializer rg -n -C3 '\bnewInputResourceInitializer\b|\binputResourceInitializer\b'

Repository: openshift/hypershift

Length of output: 8472

🏁 Script executed:

# Get the file structure and locate the Start method fd 'input_resource_initializer.go' --exec cat -n {}

Repository: openshift/hypershift

Length of output: 5887

🏁 Script executed:

# Search for where this might be registered in the manager setup rg -n -C5 'inputResourceInitializer|discoverInputResources'

Repository: openshift/hypershift

Length of output: 10105

discoverInputResources blocks manager startup with "not implemented" error.

The initializer is registered in SetupWithManager and its Start() method immediately calls discoverInputResources(), which returns an error. This prevents the manager from starting. Either implement the discovery or return an empty map temporarily to unblock startup.

💡 Suggested interim fix

func (r *inputResourceInitializer) discoverInputResources() (map[string]*libraryinputresources.InputResources, error) { - return nil, fmt.Errorf("not implemented") + // TODO: implement discovery. + return map[string]*libraryinputresources.InputResources{}, nil }

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

func (r *inputResourceInitializer) discoverInputResources() (map[string]*libraryinputresources.InputResources, error) {

return nil, fmt.Errorf("not implemented")

}

func (r *inputResourceInitializer) discoverInputResources() (map[string]*libraryinputresources.InputResources, error) {

// TODO: implement discovery.

return map[string]*libraryinputresources.InputResources{}, nil

}

🤖 Prompt for AI Agents

In `@control-plane-operator/controllers/openshiftmanager/input_resource_initializer.go` around lines 47 - 49, The discoverInputResources function currently always returns a "not implemented" error which blocks manager startup; change its implementation in the inputResourceInitializer type so it returns an empty map and nil error (e.g. make(map[string]*libraryinputresources.InputResources), nil) to unblock startup, or implement the actual discovery logic used by Start()/SetupWithManager if you prefer; locate and update discoverInputResources (and ensure any callers like Start() handle an empty map) so the manager can start successfully.

bertinatto · 2026-01-20T19:56:48Z

control-plane-operator/controllers/openshiftmanager/input_resource_dispatcher.go

+	filters := d.filters[gvk]
+	if len(filters) == 0 {
+		d.eventsCh <- event.GenericEvent{Object: cObj}
+		return


Why dispatch the event if there are no filters? Is this an oversight?

Filter will be added in #7552

ok, so i misunderstood you question.

don't have a good answer here, i can change it to return if there a no filters and we can always adjust the code.

it seems like, the initial list will contain "exact resources" only, xref: https://github.com/openshift/cluster-authentication-operator/blob/master/pkg/cmd/mom/input_resources_command.go#L18

so, it looks like we will always require some filters.

openshift-ci-robot · 2026-01-22T09:32:16Z

@p0lyn0mial: This pull request references API-1835 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.22.0" version, but no target version was set.

Details

In response to this:

requires #7477

// inputResourceDispatcher is a simple dispatcher that applies GVK scoped filters
// and forwards matching events.
//
// Each GVK has its own set of filters. Today these
// may include name/namespace checks, and in the future label selectors.
//
// Longer term, this dispatcher is expected to track which input resources are
// associated with which operator.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

inputResourceDispatcher is a simple dispatcher that applies GVK scoped filters and forwards matching events. Each GVK has its own set of filters. Today these may include name/namespace checks, and in the future label selectors. Longer term, this dispatcher is expected to track which input resources are associated with which operator.

openshift-ci · 2026-01-22T09:33:12Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csrwng, p0lyn0mial

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~control-plane-operator/controllers/openshiftmanager/OWNERS~~ [csrwng,p0lyn0mial]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

bertinatto

/lgmt

p0lyn0mial · 2026-01-22T15:26:18Z

/verified by CI

openshift-ci-robot · 2026-01-22T15:26:34Z

@p0lyn0mial: This PR has been marked as verified by CI.

Details

In response to this:

/verified by CI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

bertinatto · 2026-01-22T17:41:34Z

/lgtm

openshift-ci-robot · 2026-01-22T20:01:21Z

/retest-required

Remaining retests: 0 against base HEAD a4c53d1 and 2 for PR HEAD c7512a9 in total

p0lyn0mial · 2026-01-23T07:52:42Z

/test e2e-aws

openshift-ci-robot · 2026-01-23T13:37:54Z

/retest-required

Remaining retests: 0 against base HEAD 9f235bb and 1 for PR HEAD c7512a9 in total

openshift-ci-robot · 2026-01-23T18:37:53Z

/retest-required

Remaining retests: 0 against base HEAD 23d2d8d and 0 for PR HEAD c7512a9 in total

openshift-ci · 2026-01-23T21:04:41Z

@p0lyn0mial: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws	`c7512a9`	link	true	`/test e2e-aws`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci-robot · 2026-01-23T21:37:48Z

/hold

Revision c7512a9 was retested 3 times: holding

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 19, 2026

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 19, 2026

openshift-ci bot added the do-not-merge/needs-area label Jan 19, 2026

openshift-ci bot assigned benluddy, bertinatto and csrwng Jan 19, 2026

openshift-ci bot requested review from bertinatto and bryan-cox January 19, 2026 12:52

openshift-ci bot added area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release and removed do-not-merge/needs-area labels Jan 19, 2026

p0lyn0mial commented Jan 19, 2026

View reviewed changes

p0lyn0mial force-pushed the om-phase-2-in-res-dispatcher-stub branch from 1445b4c to d2cb8af Compare January 19, 2026 13:44

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 19, 2026

coderabbitai bot reviewed Jan 19, 2026

View reviewed changes

p0lyn0mial mentioned this pull request Jan 20, 2026

API-1835: intro dispatcher filters #7552

Open

bertinatto reviewed Jan 20, 2026

View reviewed changes

p0lyn0mial mentioned this pull request Jan 21, 2026

API-1835: wires event handlers for informers #7559

Draft

p0lyn0mial force-pushed the om-phase-2-in-res-dispatcher-stub branch from d2cb8af to 76bb8a5 Compare January 22, 2026 09:31

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 22, 2026

p0lyn0mial force-pushed the om-phase-2-in-res-dispatcher-stub branch from 76bb8a5 to c7512a9 Compare January 22, 2026 09:32

bertinatto reviewed Jan 22, 2026

View reviewed changes

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Jan 22, 2026

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 22, 2026

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 23, 2026

Conversation

p0lyn0mial commented Jan 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Jan 19, 2026 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot commented Jan 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Uh oh!

p0lyn0mial commented Jan 19, 2026

Uh oh!

openshift-ci-robot commented Jan 19, 2026 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

p0lyn0mial Jan 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

csrwng commented Jan 19, 2026

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot Jan 19, 2026

Choose a reason for hiding this comment

Uh oh!

bertinatto Jan 20, 2026

Choose a reason for hiding this comment

Uh oh!

p0lyn0mial Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

p0lyn0mial Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

p0lyn0mial Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

openshift-ci-robot commented Jan 22, 2026 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci bot commented Jan 22, 2026

Uh oh!

bertinatto left a comment

Choose a reason for hiding this comment

Uh oh!

p0lyn0mial commented Jan 22, 2026

Uh oh!

openshift-ci-robot commented Jan 22, 2026

Uh oh!

bertinatto commented Jan 22, 2026

Uh oh!

openshift-ci-robot commented Jan 22, 2026

Uh oh!

p0lyn0mial commented Jan 23, 2026

Uh oh!

openshift-ci-robot commented Jan 23, 2026

Uh oh!

openshift-ci-robot commented Jan 23, 2026

Uh oh!

openshift-ci bot commented Jan 23, 2026

Uh oh!

openshift-ci-robot commented Jan 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

p0lyn0mial commented Jan 19, 2026 •

edited

Loading

openshift-ci-robot commented Jan 19, 2026 •

edited by openshift-ci bot

Loading

coderabbitai bot commented Jan 19, 2026 •

edited

Loading

openshift-ci-robot commented Jan 19, 2026 •

edited by openshift-ci bot

Loading

p0lyn0mial Jan 19, 2026 •

edited

Loading

openshift-ci-robot commented Jan 22, 2026 •

edited by openshift-ci bot

Loading