CNTRLPLANE-2600: docs: cli flags doc generater

[devguyio]

What this PR does / why we need it:

Background

The hcp (product/customer) and hypershift (developer/internal) CLIs share underlying code but expose different sets of flags. This creates several challenges:

1. No visibility on exposed flags - There's no single place documenting which flags are exposed in the hcp CLI vs developer-only flags in hypershift
2. Risk of developer flags leaking to hcp - Without clear visibility, developer-only flags could accidentally be exposed in the product CLI
3. No CLI documentation exists - Currently there's no dedicated place in the docs for CLI flag reference
4. Required flag ambiguity - Some flags (e.g. --name and --pull-secret ) were validated as required at runtime but not marked as such in cobra, making it impossible to auto-detect requirements

Solution

This PR introduces a CLI flag documentation generator that:

1. Extracts flags programmatically from both hcp and hypershift CLI commands using the actual cobra command structures
2. Detects required flags dynamically via cobra's MarkFlagRequired and MarkPersistentFlagRequired annotations instead of hardcoding
3. Organizes flags by category using a mapping in categories.go (AWS Infrastructure, Cluster Identity, Security, Networking, etc.) for better readability
4. Generates markdown documentation comparing flags side-by-side with per-CLI availability and required status
5. Integrates with the build system via make cli-docs target (included in make update)

Changes

New hypershift docs generate command (cmd/docs/):

• generate.go - Main generator logic, extracts flags from both CLIs by walking the cobra command tree
• types.go - FlagInfo struct with RequiredInHcp and RequiredInHypershift fields for per-CLI tracking
• categories.go - Flag categorization (AWS Infrastructure, Cluster Identity, Security, etc.)
• templates/aws.md.tmpl - Template with three-state display for Required section
• generate_test.go - 27 unit tests covering flag extraction, merging, and required detection

Required flag annotations (cmd/cluster/cluster.go, product-cli/cmd/cluster/cluster.go):

• Added MarkPersistentFlagRequired("name") and MarkPersistentFlagRequired("pull-secret")
• These flags were already effectively required through runtime validation in cmd/cluster/core/create.go but not marked using cobra's mechanism

Generated documentation (docs/content/reference/cli-flags/):

• index.md - Overview page explaining hcp vs hypershift CLIs
• aws.md - Generated flag reference for create cluster aws command

Three-state display in Required section:

Symbol	Meaning
✓	Required and available in this CLI
Optional	Available but not required in this CLI
Unavailable	Flag does not exist in this CLI

Which issue(s) this PR fixes:

Fixes CNTRLPLANE-2600

Documentation Preview

📖 Preview the generated docs

Special notes for your reviewer:

1. Scope: Currently only covers AWS create cluster command. The generator is designed to be extensible to other platforms and commands.

2. Required flag detection: The generator walks up the cobra command tree to access flags directly where annotations are stored, ensuring annotations set by MarkFlagRequired and MarkPersistentFlagRequired are visible (cobra's InheritedFlags() returns copies without annotations).

3. No breaking changes: The MarkPersistentFlagRequired calls don't change runtime behavior - these flags were already validated as required. This just makes it explicit to cobra for better --help output and annotation-based detection.

4. Regenerating docs: Run make cli-docs or make update to regenerate after flag changes.

---

🤖 Generated with Claude Code

Checklist:

• Subject and description added to both, commit and PR.
• Relevant issues have been referenced.
• This change includes docs.
• This change includes unit tests.

[openshift-ci-robot]

@devguyio: This pull request references CNTRLPLANE-2600 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set.

Details

In response to this:

What this PR does / why we need it:

Background

The hcp (product/customer) and hypershift (developer/internal) CLIs share underlying code but expose different sets of flags. This creates several challenges:

1. No visibility on exposed flags - There's no single place documenting which flags are exposed in the hcp CLI vs developer-only flags in hypershift
2. Risk of developer flags leaking to hcp - Without clear visibility, developer-only flags could accidentally be exposed in the product CLI
3. No CLI documentation exists - Currently there's no dedicated place in the docs for CLI flag reference
4. Required flag ambiguity - Some flags (e.g. --name and --pull-secret ) were validated as required at runtime but not marked as such in cobra, making it impossible to auto-detect requirements

Solution

This PR introduces a CLI flag documentation generator that:

1. Extracts flags programmatically from both hcp and hypershift CLI commands using the actual cobra command structures
2. Detects required flags dynamically via cobra's MarkFlagRequired and MarkPersistentFlagRequired annotations instead of hardcoding
3. Organizes flags by category using a mapping in categories.go (AWS Infrastructure, Cluster Identity, Security, Networking, etc.) for better readability
4. Generates markdown documentation comparing flags side-by-side with per-CLI availability and required status
5. Integrates with the build system via make cli-docs target (included in make update)

Changes

New hypershift docs generate command (cmd/docs/):

• generate.go - Main generator logic, extracts flags from both CLIs by walking the cobra command tree
• types.go - FlagInfo struct with RequiredInHcp and RequiredInHypershift fields for per-CLI tracking
• categories.go - Flag categorization (AWS Infrastructure, Cluster Identity, Security, etc.)
• templates/aws.md.tmpl - Template with three-state display for Required section
• generate_test.go - 27 unit tests covering flag extraction, merging, and required detection

Required flag annotations (cmd/cluster/cluster.go, product-cli/cmd/cluster/cluster.go):

• Added MarkPersistentFlagRequired("name") and MarkPersistentFlagRequired("pull-secret")
• These flags were already effectively required through runtime validation in cmd/cluster/core/create.go but not marked using cobra's mechanism

Generated documentation (docs/content/reference/cli-flags/):

• index.md - Overview page explaining hcp vs hypershift CLIs
• aws.md - Generated flag reference for create cluster aws command

Three-state display in Required section:

Symbol	Meaning
✓	Required and available in this CLI
Optional	Available but not required in this CLI
Unavailable	Flag does not exist in this CLI

Which issue(s) this PR fixes:

Fixes CNTRLPLANE-2600

Documentation Preview

📖 Preview the generated CLI flag reference →

Special notes for your reviewer:

1. Scope: Currently only covers AWS create cluster command. The generator is designed to be extensible to other platforms and commands.

2. Required flag detection: The generator walks up the cobra command tree to access flags directly where annotations are stored, ensuring annotations set by MarkFlagRequired and MarkPersistentFlagRequired are visible (cobra's InheritedFlags() returns copies without annotations).

3. No breaking changes: The MarkPersistentFlagRequired calls don't change runtime behavior - these flags were already validated as required. This just makes it explicit to cobra for better --help output and annotation-based detection.

4. Regenerating docs: Run make cli-docs or make update to regenerate after flag changes.

---

🤖 Generated with Claude Code

Checklist:

• Subject and description added to both, commit and PR.
• Relevant issues have been referenced.
• This change includes docs.
• This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Review skipped — only excluded labels are configured. (1)

• do-not-merge/work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

• 🔍 Trigger a full review

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[openshift-ci-robot]

@devguyio: This pull request references CNTRLPLANE-2600 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set.

Details

In response to this:

What this PR does / why we need it:

Background

The hcp (product/customer) and hypershift (developer/internal) CLIs share underlying code but expose different sets of flags. This creates several challenges:

1. No visibility on exposed flags - There's no single place documenting which flags are exposed in the hcp CLI vs developer-only flags in hypershift
2. Risk of developer flags leaking to hcp - Without clear visibility, developer-only flags could accidentally be exposed in the product CLI
3. No CLI documentation exists - Currently there's no dedicated place in the docs for CLI flag reference
4. Required flag ambiguity - Some flags (e.g. --name and --pull-secret ) were validated as required at runtime but not marked as such in cobra, making it impossible to auto-detect requirements

Solution

This PR introduces a CLI flag documentation generator that:

1. Extracts flags programmatically from both hcp and hypershift CLI commands using the actual cobra command structures
2. Detects required flags dynamically via cobra's MarkFlagRequired and MarkPersistentFlagRequired annotations instead of hardcoding
3. Organizes flags by category using a mapping in categories.go (AWS Infrastructure, Cluster Identity, Security, Networking, etc.) for better readability
4. Generates markdown documentation comparing flags side-by-side with per-CLI availability and required status
5. Integrates with the build system via make cli-docs target (included in make update)

Changes

New hypershift docs generate command (cmd/docs/):

• generate.go - Main generator logic, extracts flags from both CLIs by walking the cobra command tree
• types.go - FlagInfo struct with RequiredInHcp and RequiredInHypershift fields for per-CLI tracking
• categories.go - Flag categorization (AWS Infrastructure, Cluster Identity, Security, etc.)
• templates/aws.md.tmpl - Template with three-state display for Required section
• generate_test.go - 27 unit tests covering flag extraction, merging, and required detection

Required flag annotations (cmd/cluster/cluster.go, product-cli/cmd/cluster/cluster.go):

• Added MarkPersistentFlagRequired("name") and MarkPersistentFlagRequired("pull-secret")
• These flags were already effectively required through runtime validation in cmd/cluster/core/create.go but not marked using cobra's mechanism

Generated documentation (docs/content/reference/cli-flags/):

• index.md - Overview page explaining hcp vs hypershift CLIs
• aws.md - Generated flag reference for create cluster aws command

Three-state display in Required section:

Symbol	Meaning
✓	Required and available in this CLI
Optional	Available but not required in this CLI
Unavailable	Flag does not exist in this CLI

Which issue(s) this PR fixes:

Fixes CNTRLPLANE-2600

Documentation Preview

📖 Preview the generated CLI flag reference →

Special notes for your reviewer:

1. Scope: Currently only covers AWS create cluster command. The generator is designed to be extensible to other platforms and commands.

2. Required flag detection: The generator walks up the cobra command tree to access flags directly where annotations are stored, ensuring annotations set by MarkFlagRequired and MarkPersistentFlagRequired are visible (cobra's InheritedFlags() returns copies without annotations).

3. No breaking changes: The MarkPersistentFlagRequired calls don't change runtime behavior - these flags were already validated as required. This just makes it explicit to cobra for better --help output and annotation-based detection.

4. Regenerating docs: Run make cli-docs or make update to regenerate after flag changes.

---

🤖 Generated with Claude Code

Checklist:

• Subject and description added to both, commit and PR.
• Relevant issues have been referenced.
• This change includes docs.
• This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@devguyio: This pull request references CNTRLPLANE-2600 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set.

Details

In response to this:

What this PR does / why we need it:

Background

The hcp (product/customer) and hypershift (developer/internal) CLIs share underlying code but expose different sets of flags. This creates several challenges:

1. No visibility on exposed flags - There's no single place documenting which flags are exposed in the hcp CLI vs developer-only flags in hypershift
2. Risk of developer flags leaking to hcp - Without clear visibility, developer-only flags could accidentally be exposed in the product CLI
3. No CLI documentation exists - Currently there's no dedicated place in the docs for CLI flag reference
4. Required flag ambiguity - Some flags (e.g. --name and --pull-secret ) were validated as required at runtime but not marked as such in cobra, making it impossible to auto-detect requirements

Solution

This PR introduces a CLI flag documentation generator that:

1. Extracts flags programmatically from both hcp and hypershift CLI commands using the actual cobra command structures
2. Detects required flags dynamically via cobra's MarkFlagRequired and MarkPersistentFlagRequired annotations instead of hardcoding
3. Organizes flags by category using a mapping in categories.go (AWS Infrastructure, Cluster Identity, Security, Networking, etc.) for better readability
4. Generates markdown documentation comparing flags side-by-side with per-CLI availability and required status
5. Integrates with the build system via make cli-docs target (included in make update)

Changes

New hypershift docs generate command (cmd/docs/):

• generate.go - Main generator logic, extracts flags from both CLIs by walking the cobra command tree
• types.go - FlagInfo struct with RequiredInHcp and RequiredInHypershift fields for per-CLI tracking
• categories.go - Flag categorization (AWS Infrastructure, Cluster Identity, Security, etc.)
• templates/aws.md.tmpl - Template with three-state display for Required section
• generate_test.go - 27 unit tests covering flag extraction, merging, and required detection

Required flag annotations (cmd/cluster/cluster.go, product-cli/cmd/cluster/cluster.go):

• Added MarkPersistentFlagRequired("name") and MarkPersistentFlagRequired("pull-secret")
• These flags were already effectively required through runtime validation in cmd/cluster/core/create.go but not marked using cobra's mechanism

Generated documentation (docs/content/reference/cli-flags/):

• index.md - Overview page explaining hcp vs hypershift CLIs
• aws.md - Generated flag reference for create cluster aws command

Three-state display in Required section:

Symbol	Meaning
✓	Required and available in this CLI
Optional	Available but not required in this CLI
Unavailable	Flag does not exist in this CLI

Which issue(s) this PR fixes:

Fixes CNTRLPLANE-2600

Documentation Preview

Special notes for your reviewer:

1. Scope: Currently only covers AWS create cluster command. The generator is designed to be extensible to other platforms and commands.

2. Required flag detection: The generator walks up the cobra command tree to access flags directly where annotations are stored, ensuring annotations set by MarkFlagRequired and MarkPersistentFlagRequired are visible (cobra's InheritedFlags() returns copies without annotations).

3. No breaking changes: The MarkPersistentFlagRequired calls don't change runtime behavior - these flags were already validated as required. This just makes it explicit to cobra for better --help output and annotation-based detection.

4. Regenerating docs: Run make cli-docs or make update to regenerate after flag changes.

---

🤖 Generated with Claude Code

Checklist:

• Subject and description added to both, commit and PR.
• Relevant issues have been referenced.
• This change includes docs.
• This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@devguyio: This pull request references CNTRLPLANE-2600 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set.

Details

In response to this:

What this PR does / why we need it:

Background

The hcp (product/customer) and hypershift (developer/internal) CLIs share underlying code but expose different sets of flags. This creates several challenges:

1. No visibility on exposed flags - There's no single place documenting which flags are exposed in the hcp CLI vs developer-only flags in hypershift
2. Risk of developer flags leaking to hcp - Without clear visibility, developer-only flags could accidentally be exposed in the product CLI
3. No CLI documentation exists - Currently there's no dedicated place in the docs for CLI flag reference
4. Required flag ambiguity - Some flags (e.g. --name and --pull-secret ) were validated as required at runtime but not marked as such in cobra, making it impossible to auto-detect requirements

Solution

This PR introduces a CLI flag documentation generator that:

1. Extracts flags programmatically from both hcp and hypershift CLI commands using the actual cobra command structures
2. Detects required flags dynamically via cobra's MarkFlagRequired and MarkPersistentFlagRequired annotations instead of hardcoding
3. Organizes flags by category using a mapping in categories.go (AWS Infrastructure, Cluster Identity, Security, Networking, etc.) for better readability
4. Generates markdown documentation comparing flags side-by-side with per-CLI availability and required status
5. Integrates with the build system via make cli-docs target (included in make update)

Changes

New hypershift docs generate command (cmd/docs/):

• generate.go - Main generator logic, extracts flags from both CLIs by walking the cobra command tree
• types.go - FlagInfo struct with RequiredInHcp and RequiredInHypershift fields for per-CLI tracking
• categories.go - Flag categorization (AWS Infrastructure, Cluster Identity, Security, etc.)
• templates/aws.md.tmpl - Template with three-state display for Required section
• generate_test.go - 27 unit tests covering flag extraction, merging, and required detection

Required flag annotations (cmd/cluster/cluster.go, product-cli/cmd/cluster/cluster.go):

• Added MarkPersistentFlagRequired("name") and MarkPersistentFlagRequired("pull-secret")
• These flags were already effectively required through runtime validation in cmd/cluster/core/create.go but not marked using cobra's mechanism

Generated documentation (docs/content/reference/cli-flags/):

• index.md - Overview page explaining hcp vs hypershift CLIs
• aws.md - Generated flag reference for create cluster aws command

Three-state display in Required section:

Symbol	Meaning
✓	Required and available in this CLI
Optional	Available but not required in this CLI
Unavailable	Flag does not exist in this CLI

Which issue(s) this PR fixes:

Fixes CNTRLPLANE-2600

Documentation Preview

Special notes for your reviewer:

1. Scope: Currently only covers AWS create cluster command. The generator is designed to be extensible to other platforms and commands.

2. Required flag detection: The generator walks up the cobra command tree to access flags directly where annotations are stored, ensuring annotations set by MarkFlagRequired and MarkPersistentFlagRequired are visible (cobra's InheritedFlags() returns copies without annotations).

3. No breaking changes: The MarkPersistentFlagRequired calls don't change runtime behavior - these flags were already validated as required. This just makes it explicit to cobra for better --help output and annotation-based detection.

4. Regenerating docs: Run make cli-docs or make update to regenerate after flag changes.

---

🤖 Generated with Claude Code

Checklist:

• Subject and description added to both, commit and PR.
• Relevant issues have been referenced.
• This change includes docs.
• This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: devguyio

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [devguyio]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[devguyio]

/test ?

[openshift-ci]

@devguyio: The following commands are available to trigger required jobs:

/test e2e-aks

/test e2e-aks-4-21

/test e2e-aks-override

/test e2e-aws

/test e2e-aws-4-21

/test e2e-aws-override

/test e2e-aws-upgrade-hypershift-operator

/test e2e-kubevirt-aws-ovn-reduced

/test images

/test okd-scos-images

/test security

/test unit

/test verify

/test verify-deps

The following commands are available to trigger optional jobs:

/test docs-preview

/test e2e-aws-autonode

/test e2e-aws-metrics

/test e2e-aws-minimal

/test e2e-aws-techpreview

/test e2e-azure-aks-ovn-conformance

/test e2e-conformance

/test e2e-kubevirt-aws-ovn

/test e2e-kubevirt-azure-ovn

/test e2e-kubevirt-metal-conformance

/test e2e-openstack-aws

/test e2e-openstack-aws-conformance

/test e2e-openstack-aws-csi-cinder

/test e2e-openstack-aws-csi-manila

/test e2e-openstack-aws-nfv

/test okd-scos-e2e-aws-ovn

/test reqserving-e2e-aws

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-hypershift-main-docs-preview

pull-ci-openshift-hypershift-main-e2e-aks

pull-ci-openshift-hypershift-main-e2e-aks-4-21

pull-ci-openshift-hypershift-main-e2e-aws

pull-ci-openshift-hypershift-main-e2e-aws-upgrade-hypershift-operator

pull-ci-openshift-hypershift-main-e2e-kubevirt-aws-ovn-reduced

pull-ci-openshift-hypershift-main-images

pull-ci-openshift-hypershift-main-okd-scos-images

pull-ci-openshift-hypershift-main-security

pull-ci-openshift-hypershift-main-unit

pull-ci-openshift-hypershift-main-verify

Details

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[devguyio]

/test docs-preview

[openshift-ci]

@devguyio: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci-robot]

@devguyio: This pull request references CNTRLPLANE-2600 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set.

Details

In response to this:

What this PR does / why we need it:

Background

The hcp (product/customer) and hypershift (developer/internal) CLIs share underlying code but expose different sets of flags. This creates several challenges:

1. No visibility on exposed flags - There's no single place documenting which flags are exposed in the hcp CLI vs developer-only flags in hypershift
2. Risk of developer flags leaking to hcp - Without clear visibility, developer-only flags could accidentally be exposed in the product CLI
3. No CLI documentation exists - Currently there's no dedicated place in the docs for CLI flag reference
4. Required flag ambiguity - Some flags (e.g. --name and --pull-secret ) were validated as required at runtime but not marked as such in cobra, making it impossible to auto-detect requirements

Solution

This PR introduces a CLI flag documentation generator that:

1. Extracts flags programmatically from both hcp and hypershift CLI commands using the actual cobra command structures
2. Detects required flags dynamically via cobra's MarkFlagRequired and MarkPersistentFlagRequired annotations instead of hardcoding
3. Organizes flags by category using a mapping in categories.go (AWS Infrastructure, Cluster Identity, Security, Networking, etc.) for better readability
4. Generates markdown documentation comparing flags side-by-side with per-CLI availability and required status
5. Integrates with the build system via make cli-docs target (included in make update)

Changes

New hypershift docs generate command (cmd/docs/):

• generate.go - Main generator logic, extracts flags from both CLIs by walking the cobra command tree
• types.go - FlagInfo struct with RequiredInHcp and RequiredInHypershift fields for per-CLI tracking
• categories.go - Flag categorization (AWS Infrastructure, Cluster Identity, Security, etc.)
• templates/aws.md.tmpl - Template with three-state display for Required section
• generate_test.go - 27 unit tests covering flag extraction, merging, and required detection

Required flag annotations (cmd/cluster/cluster.go, product-cli/cmd/cluster/cluster.go):

• Added MarkPersistentFlagRequired("name") and MarkPersistentFlagRequired("pull-secret")
• These flags were already effectively required through runtime validation in cmd/cluster/core/create.go but not marked using cobra's mechanism

Generated documentation (docs/content/reference/cli-flags/):

• index.md - Overview page explaining hcp vs hypershift CLIs
• aws.md - Generated flag reference for create cluster aws command

Three-state display in Required section:

Symbol	Meaning
✓	Required and available in this CLI
Optional	Available but not required in this CLI
Unavailable	Flag does not exist in this CLI

Which issue(s) this PR fixes:

Fixes CNTRLPLANE-2600

Documentation Preview

📖 Preview the generated docs

Special notes for your reviewer:

1. Scope: Currently only covers AWS create cluster command. The generator is designed to be extensible to other platforms and commands.

2. Required flag detection: The generator walks up the cobra command tree to access flags directly where annotations are stored, ensuring annotations set by MarkFlagRequired and MarkPersistentFlagRequired are visible (cobra's InheritedFlags() returns copies without annotations).

3. No breaking changes: The MarkPersistentFlagRequired calls don't change runtime behavior - these flags were already validated as required. This just makes it explicit to cobra for better --help output and annotation-based detection.

4. Regenerating docs: Run make cli-docs or make update to regenerate after flag changes.

---

🤖 Generated with Claude Code

Checklist:

• Subject and description added to both, commit and PR.
• Relevant issues have been referenced.
• This change includes docs.
• This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[devguyio]

/auto-cc

[jparrill]

Thanks for the PR. Overall looks good. Some minor nits dropped

[jparrill]

When processing hypershift flags, you uses flag.RequiredInHcp instead of flag.RequiredInHypershift:

• existing.RequiredInHypershift = flag.RequiredInHcp // line 234
• f.RequiredInHypershift = f.RequiredInHcp // line 239

It Works because addFlagToMap sets both fields to the same value, but it's confusing and error-prone if addFlagToMap changes.
Do you mind use flag.RequiredInHypershift explicitly?

[jparrill]

Not sure why you use {{ cat.Name }} vs {{ .Name }}? are those different? if not could we just use one?

[openshift-merge-robot]

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.