Skip to content

WIP: Add configsync condition#7581

Draft
devguyio wants to merge 3 commits intoopenshift:mainfrom
devguyio:add-configsync-condition
Draft

WIP: Add configsync condition#7581
devguyio wants to merge 3 commits intoopenshift:mainfrom
devguyio:add-configsync-condition

Conversation

@devguyio
Copy link
Contributor

@devguyio devguyio commented Jan 23, 2026

Warning

Very rough code that I didn't thoroughly review.

What this PR does / why we need it:

Adds a new HostedClusterConfigSynced condition to surface HCCO config sync errors to users.

When reconcileConfig fails, the error is now visible via a condition on HCP/HC instead of failing silently with infinite retries.

Which issue(s) this PR fixes:

Fixes

Special notes for your reviewer:

  • Uses typed errors (ConfigSyncError, ConfigSyncErrors) to determine failure reason
  • Condition reasons: InfrastructureSyncFailed, DNSSyncFailed, IngressSyncFailed, NetworkSyncFailed, MultipleConfigSyncFailed
  • Condition added to expected e2e conditions with a version guardrail for clusters < 4.22

Checklist:

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 23, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 23, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 23, 2026

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Review skipped — only excluded labels are configured. (1)
  • do-not-merge/work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci bot added do-not-merge/needs-area area/api Indicates the PR includes changes for the API labels Jan 23, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 23, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: devguyio

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation Indicates the PR includes changes for documentation area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release area/testing Indicates the PR includes changes for e2e testing and removed do-not-merge/needs-area labels Jan 23, 2026
devguyio and others added 3 commits January 23, 2026 22:23
Add a new condition type to surface HCCO config sync errors to users.

🤖 Generated with Claude Code v2.1.6

Co-Authored-By: Claude Opus 4.5 (claude-opus-4-5-20251101) <noreply@anthropic.com>
Signed-off-by: Ahmed Abdalla <aabdelre@redhat.com>
Add ConfigSyncError and ConfigSyncErrors types to track which specific
config failed to sync (Infrastructure, DNS, Ingress, Network, etc.).

🤖 Generated with Claude Code v2.1.6

Co-Authored-By: Claude Opus 4.5 (claude-opus-4-5-20251101) <noreply@anthropic.com>
Signed-off-by: Ahmed Abdalla <aabdelre@redhat.com>
Set condition on HCP based on reconcileConfig success/failure. Uses typed
errors to determine specific failure reason (Infrastructure, DNS, etc.).
Bubble up condition from HCP to HC. Add expected condition state and
version guardrail for e2e tests (skip for versions < 4.22).

🤖 Generated with Claude Code v2.1.6

Co-Authored-By: Claude Opus 4.5 (claude-opus-4-5-20251101) <noreply@anthropic.com>
Signed-off-by: Ahmed Abdalla <aabdelre@redhat.com>
@devguyio devguyio force-pushed the add-configsync-condition branch from dccc11d to a2cd03a Compare January 23, 2026 21:23
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 26, 2026
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/api Indicates the PR includes changes for the API area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release area/documentation Indicates the PR includes changes for documentation area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release area/testing Indicates the PR includes changes for e2e testing do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants