Conversation
|
Skipping CI for Draft Pull Request. |
|
Important Review skippedAuto reviews are limited based on label configuration. 🚫 Review skipped — only excluded labels are configured. (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: devguyio The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Add a new condition type to surface HCCO config sync errors to users. 🤖 Generated with Claude Code v2.1.6 Co-Authored-By: Claude Opus 4.5 (claude-opus-4-5-20251101) <noreply@anthropic.com> Signed-off-by: Ahmed Abdalla <aabdelre@redhat.com>
Add ConfigSyncError and ConfigSyncErrors types to track which specific config failed to sync (Infrastructure, DNS, Ingress, Network, etc.). 🤖 Generated with Claude Code v2.1.6 Co-Authored-By: Claude Opus 4.5 (claude-opus-4-5-20251101) <noreply@anthropic.com> Signed-off-by: Ahmed Abdalla <aabdelre@redhat.com>
Set condition on HCP based on reconcileConfig success/failure. Uses typed errors to determine specific failure reason (Infrastructure, DNS, etc.). Bubble up condition from HCP to HC. Add expected condition state and version guardrail for e2e tests (skip for versions < 4.22). 🤖 Generated with Claude Code v2.1.6 Co-Authored-By: Claude Opus 4.5 (claude-opus-4-5-20251101) <noreply@anthropic.com> Signed-off-by: Ahmed Abdalla <aabdelre@redhat.com>
dccc11d to
a2cd03a
Compare
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Warning
Very rough code that I didn't thoroughly review.
What this PR does / why we need it:
Adds a new
HostedClusterConfigSyncedcondition to surface HCCO config sync errors to users.When
reconcileConfigfails, the error is now visible via a condition on HCP/HC instead of failing silently with infinite retries.Which issue(s) this PR fixes:
Fixes
Special notes for your reviewer:
ConfigSyncError,ConfigSyncErrors) to determine failure reasonInfrastructureSyncFailed,DNSSyncFailed,IngressSyncFailed,NetworkSyncFailed,MultipleConfigSyncFailedChecklist: