OCPBUGS-75931: [release-4.20] fix(cpo): Correct route labeling logic for HCP router infrastructure by csrwng · Pull Request #7642 · openshift/hypershift

csrwng · 2026-02-05T04:01:16Z

Manual backport of #7641

openshift-ci · 2026-02-05T04:01:19Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

coderabbitai · 2026-02-05T04:01:27Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

csrwng · 2026-02-05T04:01:29Z

/test verify
/test unit

openshift-ci · 2026-02-05T04:01:30Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csrwng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [csrwng]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

csrwng · 2026-02-05T04:24:08Z

/jira cherry-pick OCPBUGS-75930

openshift-ci-robot · 2026-02-05T04:25:20Z

@csrwng: Jira Issue OCPBUGS-75930 has been cloned as Jira Issue OCPBUGS-75931. Will retitle bug to link to clone.
/retitle OCPBUGS-75931: [release-4.20] fix(cpo): Correct route labeling logic for HCP router infrastructure

Details

In response to this:

/jira cherry-pick OCPBUGS-75930

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2026-02-05T04:25:31Z

@csrwng: This pull request references Jira Issue OCPBUGS-75931, which is invalid:

expected dependent Jira Issue OCPBUGS-75930 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is New instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Manual backport of #7641

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

csrwng · 2026-02-08T03:29:27Z

/make test
/make verify

…ions Fixed upgrade failures caused by unexpected router LoadBalancer creation. Previous logic incorrectly made per-service route labeling decisions, creating router infrastructure even when routes should use the management cluster router. Changed route labeling to cluster-level decision based on KAS publishing strategy. Routes now use HCP router only when: (1) cluster uses PrivateLink, OR (2) cluster is public with dedicated DNS for KAS. Added LabelHCPRoutes() as single source of truth. Removed per-service DNS helper functions and IsPublicWithDNS() functions that caused inconsistent labeling. Signed-off-by: Cesar Wong <cewong@redhat.com> Commit-Message-Assisted-by: Claude (via Claude Code)

openshift-ci · 2026-02-20T18:18:56Z

@csrwng: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

csrwng · 2026-02-27T01:16:10Z

/jira refresh

openshift-ci-robot · 2026-02-27T01:16:14Z

@csrwng: This pull request references Jira Issue OCPBUGS-75931, which is invalid:

expected dependent Jira Issue OCPBUGS-75930 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

csrwng · 2026-02-27T01:16:28Z

/verified later @heliubj18

openshift-ci-robot · 2026-02-27T01:16:41Z

@csrwng: This PR has been marked to be verified later by @heliubj18.

Details

In response to this:

/verified later @heliubj18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

enxebre · 2026-02-27T10:49:51Z

/lgtm

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 5, 2026

openshift-ci bot added the do-not-merge/needs-area label Feb 5, 2026

openshift-ci bot added the area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release label Feb 5, 2026

openshift-ci bot added area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/needs-area labels Feb 5, 2026

csrwng mentioned this pull request Feb 5, 2026

OCPBUGS-75932: [release-4.19] fix(cpo): Correct route labeling logic for HCP router infrastructure #7643

Open

openshift-ci bot changed the title ~~[release-4.20] fix(cpo): Correct route labeling logic for HCP router infrastructure~~ OCPBUGS-75931: [release-4.20] fix(cpo): Correct route labeling logic for HCP router infrastructure Feb 5, 2026

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 5, 2026

csrwng force-pushed the private_router_fix_420 branch from 6316ce8 to 14d91ca Compare February 5, 2026 19:43

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 5, 2026

csrwng force-pushed the private_router_fix_420 branch from 14d91ca to 88f92ce Compare February 8, 2026 03:29

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 8, 2026

csrwng force-pushed the private_router_fix_420 branch 2 times, most recently from 26a80af to 5844d49 Compare February 10, 2026 18:28

csrwng force-pushed the private_router_fix_420 branch from 5844d49 to 2ff9e18 Compare February 17, 2026 23:22

csrwng marked this pull request as ready for review February 19, 2026 22:36

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 19, 2026

openshift-ci bot requested review from enxebre and hasueki February 19, 2026 22:37

csrwng added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Feb 19, 2026

csrwng force-pushed the private_router_fix_420 branch from 2ff9e18 to 0eb3400 Compare February 20, 2026 03:21

csrwng force-pushed the private_router_fix_420 branch from 0eb3400 to 4d705c4 Compare February 20, 2026 16:21

openshift-ci-robot added verified-later verified Signifies that the PR passed pre-merge verification criteria labels Feb 27, 2026

openshift-ci bot assigned enxebre Feb 27, 2026

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 27, 2026

Conversation

csrwng commented Feb 5, 2026

Uh oh!

openshift-ci bot commented Feb 5, 2026

Uh oh!

coderabbitai bot commented Feb 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

csrwng commented Feb 5, 2026

Uh oh!

openshift-ci bot commented Feb 5, 2026

Uh oh!

csrwng commented Feb 5, 2026

Uh oh!

openshift-ci-robot commented Feb 5, 2026

Uh oh!

openshift-ci-robot commented Feb 5, 2026

Uh oh!

csrwng commented Feb 8, 2026

Uh oh!

openshift-ci bot commented Feb 20, 2026

Uh oh!

csrwng commented Feb 27, 2026

Uh oh!

openshift-ci-robot commented Feb 27, 2026

Uh oh!

csrwng commented Feb 27, 2026

Uh oh!

openshift-ci-robot commented Feb 27, 2026

Uh oh!

enxebre commented Feb 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

coderabbitai bot commented Feb 5, 2026 •

edited

Loading