Skip to content

NO-JIRA: bug(metrics): fix typo in hypershift_cluster_waiting_initial_availability_duration_seconds metric#7730

Open
joshbranham wants to merge 1 commit intoopenshift:mainfrom
joshbranham:bug-fix-WaitingInitialAvailabilityDurationMetricName
Open

NO-JIRA: bug(metrics): fix typo in hypershift_cluster_waiting_initial_availability_duration_seconds metric#7730
joshbranham wants to merge 1 commit intoopenshift:mainfrom
joshbranham:bug-fix-WaitingInitialAvailabilityDurationMetricName

Conversation

@joshbranham
Copy link

@joshbranham joshbranham commented Feb 16, 2026

The metric hypershift_cluster_waiting_initial_availbility_duration_seconds had a typo in the word availabilty. This fixes that. Consumers will need to adjust their alerting as such.

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes

Special notes for your reviewer:

Checklist:

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

@openshift-ci-robot
Copy link

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 16, 2026

No actionable comments were generated in the recent review. 🎉


Walkthrough

Fixes a typographical error in the metric name constant WaitingInitialAvailabilityDurationMetricName, changing the metric identifier string from "hypershift_cluster_waiting_initial_avaibility_duration_seconds" to "hypershift_cluster_waiting_initial_availability_duration_seconds".

Changes

Cohort / File(s) Summary
Metrics Constant Typo Fix
hypershift-operator/controllers/hostedcluster/metrics/metrics.go
Corrects the metric name string: "hypershift_cluster_waiting_initial_avaibility_duration_seconds""hypershift_cluster_waiting_initial_availability_duration_seconds".

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci bot requested review from enxebre and muraee February 16, 2026 20:36
@openshift-ci openshift-ci bot added area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release and removed do-not-merge/needs-area labels Feb 16, 2026
@joshbranham joshbranham force-pushed the bug-fix-WaitingInitialAvailabilityDurationMetricName branch from e5fc4c3 to ea54f02 Compare February 16, 2026 20:38
@joshbranham joshbranham changed the title bug(metrics): fix typo in hypershift_cluster_waiting_initial_availbility_duration_seconds metric bug(metrics): fix typo in hypershift_cluster_waiting_initial_availability_duration_seconds metric Feb 16, 2026
@csrwng
Copy link
Contributor

csrwng commented Feb 16, 2026

The change looks good to me. However @joshbranham you would likely know better than the engineering team if this will impact dashboards or any other aggregation done on the service side.

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 16, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csrwng, joshbranham

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 16, 2026
…ity_duration_seconds metric

The metric `hypershift_cluster_waiting_initial_availbility_duration_seconds` had a typo in the word
`availability`. This fixes that. Consumers will need to adjust their alerting as such.
@joshbranham joshbranham force-pushed the bug-fix-WaitingInitialAvailabilityDurationMetricName branch from ea54f02 to 6b9eb30 Compare February 16, 2026 21:19
@joshbranham
Copy link
Author

/verified
/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 17, 2026

@joshbranham: you cannot LGTM your own PR.

Details

In response to this:

/verified
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci-robot
Copy link

@joshbranham: The /verified command must be used with one of the following actions: by, later, remove, or bypass. See https://docs.ci.openshift.org/docs/architecture/jira/#premerge-verification for more information.

Details

In response to this:

/verified
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@joshbranham
Copy link
Author

/verified by @joshbranham

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Feb 17, 2026
@openshift-ci-robot
Copy link

@joshbranham: This PR has been marked as verified by @joshbranham.

Details

In response to this:

/verified by @joshbranham

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@joshbranham joshbranham changed the title bug(metrics): fix typo in hypershift_cluster_waiting_initial_availability_duration_seconds metric NO-JIRA: bug(metrics): fix typo in hypershift_cluster_waiting_initial_availability_duration_seconds metric Feb 17, 2026
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 17, 2026
@openshift-ci-robot
Copy link

@joshbranham: This pull request explicitly references no jira issue.

Details

In response to this:

The metric hypershift_cluster_waiting_initial_availbility_duration_seconds had a typo in the word availabilty. This fixes that. Consumers will need to adjust their alerting as such.

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes

Special notes for your reviewer:

Checklist:

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@enxebre
Copy link
Member

enxebre commented Feb 19, 2026

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 19, 2026
@openshift-ci-robot
Copy link

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aks-4-21
/test e2e-aws-4-21
/test e2e-aks
/test e2e-aws
/test e2e-aws-upgrade-hypershift-operator
/test e2e-kubevirt-aws-ovn-reduced
/test e2e-v2-aws

@joshbranham
Copy link
Author

/test e2e-aws-4-21
/test e2e-aks
/test e2e-aks-4-21

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 19, 2026

@joshbranham: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aks 6b9eb30 link true /test e2e-aks
ci/prow/e2e-aws-4-21 6b9eb30 link true /test e2e-aws-4-21

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants