NO-JIRA: bug(metrics): fix typo in hypershift_cluster_waiting_initial_availability_duration_seconds metric#7730
Conversation
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
|
No actionable comments were generated in the recent review. 🎉 WalkthroughFixes a typographical error in the metric name constant Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes ✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
e5fc4c3 to
ea54f02
Compare
hypershift_cluster_waiting_initial_availbility_duration_seconds metrichypershift_cluster_waiting_initial_availability_duration_seconds metric
|
The change looks good to me. However @joshbranham you would likely know better than the engineering team if this will impact dashboards or any other aggregation done on the service side. /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: csrwng, joshbranham The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…ity_duration_seconds metric The metric `hypershift_cluster_waiting_initial_availbility_duration_seconds` had a typo in the word `availability`. This fixes that. Consumers will need to adjust their alerting as such.
ea54f02 to
6b9eb30
Compare
|
/verified |
|
@joshbranham: you cannot LGTM your own PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@joshbranham: The DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/verified by @joshbranham |
|
@joshbranham: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
hypershift_cluster_waiting_initial_availability_duration_seconds metrichypershift_cluster_waiting_initial_availability_duration_seconds metric
|
@joshbranham: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/lgtm |
|
Scheduling tests matching the |
|
/test e2e-aws-4-21 |
|
@joshbranham: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
The metric
hypershift_cluster_waiting_initial_availbility_duration_secondshad a typo in the wordavailabilty. This fixes that. Consumers will need to adjust their alerting as such.What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes
Special notes for your reviewer:
Checklist: