Skip to content

CNTRLPLANE-2808: bump golang.org/x dependencies in / and /api modules#7818

Open
jparrill wants to merge 1 commit intoopenshift:mainfrom
jparrill:CNTRLPLANE-2808
Open

CNTRLPLANE-2808: bump golang.org/x dependencies in / and /api modules#7818
jparrill wants to merge 1 commit intoopenshift:mainfrom
jparrill:CNTRLPLANE-2808

Conversation

@jparrill
Copy link
Contributor

@jparrill jparrill commented Feb 27, 2026

Summary

  • Updates golang.org/x/crypto, net, oauth2, sys, term, text, mod and tools to latest versions
  • Applies the update to both the root module (/) and the API module (/api/), keeping vendor directories in sync
  • Fixes the inconsistent vendoring issue seen in Dependabot PR build(deps): bump the golang-dependencies group with 3 updates #7718, where only the root module was updated

Context

Dependabot treats / and /api/ as independent modules and generates separate PRs for each. When shared golang.org/x/* dependencies are bumped only in the root module, make verify fails because api/vendor/modules.txt is out of sync with api/go.mod.

Test plan

  • make verify passes (CI)
  • make build passes (CI)
  • make test passes (CI)

🤖 Generated with Claude Code

Summary by CodeRabbit

Release Notes

  • Chores
    • Updated multiple Go module dependencies to newer versions.

Update golang.org/x/crypto, net, oauth2, sys, term, text and tools
to their latest versions in both the root module and the api module,
ensuring vendor directories stay in sync.

Updated versions:
- golang.org/x/crypto: v0.47.0 → v0.48.0
- golang.org/x/net: v0.49.0 → v0.51.0
- golang.org/x/oauth2: v0.34.0 → v0.35.0
- golang.org/x/sys: v0.40.0 → v0.41.0
- golang.org/x/term: v0.39.0 → v0.40.0
- golang.org/x/text: v0.33.0 → v0.34.0
- golang.org/x/mod: v0.31.0 → v0.32.0
- golang.org/x/tools: v0.40.0 → v0.41.0

Ref: CNTRLPLANE-2808

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Juan Manuel Parrilla Madrid <jparrill@redhat.com>
@openshift-ci-robot
Copy link

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 27, 2026

Walkthrough

Multiple Go module dependencies are updated across api/go.mod and go.mod to newer patch and minor versions, including golang.org/x packages for networking, cryptography, OAuth2, and utilities. No code or API changes are involved.

Changes

Cohort / File(s) Summary
Go Module Dependencies
api/go.mod, go.mod
Updated indirect and direct golang.org/x dependencies (crypto, net, oauth2, sys, term, text, mod, tools) to newer patch/minor versions. No functional code changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Stable And Deterministic Test Names ✅ Passed Pull request modifies only Go module dependency files (go.mod and go.sum) with no changes to test files, making the dynamic test names check inapplicable.
Test Structure And Quality ✅ Passed PR contains only Go module manifest changes with no test code modifications, so test quality requirements do not apply.
Title check ✅ Passed The title clearly and specifically describes the main change: bumping golang.org/x dependencies in multiple modules, which matches the changeset exactly.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci bot requested review from bryan-cox and devguyio February 27, 2026 10:00
@openshift-ci openshift-ci bot added area/api Indicates the PR includes changes for the API approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/needs-area labels Feb 27, 2026
@jparrill
Copy link
Contributor Author

/area ci-tooling

@jparrill
Copy link
Contributor Author

/area api remove

@openshift-ci openshift-ci bot added the area/ci-tooling Indicates the PR includes changes for CI or tooling label Feb 27, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 27, 2026

@jparrill: The label(s) area/remove cannot be applied, because the repository doesn't have them.

Details

In response to this:

/area api remove

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jparrill jparrill changed the title build(deps): bump golang.org/x dependencies in / and /api modules CNTRLPLANE-2808: bump golang.org/x dependencies in / and /api modules Feb 27, 2026
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 27, 2026
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 27, 2026

@jparrill: This pull request references CNTRLPLANE-2808 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Summary

  • Updates golang.org/x/crypto, net, oauth2, sys, term, text, mod and tools to latest versions
  • Applies the update to both the root module (/) and the API module (/api/), keeping vendor directories in sync
  • Fixes the inconsistent vendoring issue seen in Dependabot PR build(deps): bump the golang-dependencies group with 3 updates #7718, where only the root module was updated

Context

Dependabot treats / and /api/ as independent modules and generates separate PRs for each. When shared golang.org/x/* dependencies are bumped only in the root module, make verify fails because api/vendor/modules.txt is out of sync with api/go.mod.

Supersedes #7718

Ref: CNTRLPLANE-2808

Test plan

  • make verify passes (CI)
  • make build passes (CI)
  • make test passes (CI)

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 27, 2026

@jparrill: This pull request references CNTRLPLANE-2808 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Summary

  • Updates golang.org/x/crypto, net, oauth2, sys, term, text, mod and tools to latest versions
  • Applies the update to both the root module (/) and the API module (/api/), keeping vendor directories in sync
  • Fixes the inconsistent vendoring issue seen in Dependabot PR build(deps): bump the golang-dependencies group with 3 updates #7718, where only the root module was updated

Context

Dependabot treats / and /api/ as independent modules and generates separate PRs for each. When shared golang.org/x/* dependencies are bumped only in the root module, make verify fails because api/vendor/modules.txt is out of sync with api/go.mod.

Test plan

  • make verify passes (CI)
  • make build passes (CI)
  • make test passes (CI)

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 27, 2026

@jparrill: This pull request references CNTRLPLANE-2808 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Summary

  • Updates golang.org/x/crypto, net, oauth2, sys, term, text, mod and tools to latest versions
  • Applies the update to both the root module (/) and the API module (/api/), keeping vendor directories in sync
  • Fixes the inconsistent vendoring issue seen in Dependabot PR build(deps): bump the golang-dependencies group with 3 updates #7718, where only the root module was updated

Context

Dependabot treats / and /api/ as independent modules and generates separate PRs for each. When shared golang.org/x/* dependencies are bumped only in the root module, make verify fails because api/vendor/modules.txt is out of sync with api/go.mod.

Test plan

  • make verify passes (CI)
  • make build passes (CI)
  • make test passes (CI)

🤖 Generated with Claude Code

Summary by CodeRabbit

Release Notes

  • Chores
  • Updated multiple Go module dependencies to newer versions.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 27, 2026

@jparrill: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Member

@bryan-cox bryan-cox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 27, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 27, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox, jparrill

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bryan-cox
Copy link
Member

/verified bypass

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Feb 27, 2026
@openshift-ci-robot
Copy link

@bryan-cox: The verified label has been added.

Details

In response to this:

/verified bypass

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/api Indicates the PR includes changes for the API area/ci-tooling Indicates the PR includes changes for CI or tooling jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants