-
Notifications
You must be signed in to change notification settings - Fork 1.5k
*: add missing etcd-client-ca secret #1719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Sam Batschelet <[email protected]>
vrutkovs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, hexfusion, vrutkovs The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
We already have the keys in the template because they used to be used by the similar, but differently namespaced, secret removed here. That secret was born deprecated here. Do we still believe it's deprecated? /hold |
@hexfusion is going to file a follow up to clean up the deprecated CA consolidating to one. |
|
Please @openshift-bot /hold cancel |
|
/hold |
|
@hexfusion: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
If I keep trying I will get it right eventually work carried forward via #1720 /joke |
For disaster recovery, we need to persist the etcd-client-ca.{crt,key} which allows us to regenerate etcd certificates. While the cert is persisted to disk we do not have the key. For now, this adds the secret to
openshift-configalong with the other etcd related TLS assets.installer/data/data/bootstrap/files/usr/local/bin/bootkube.sh.template
Lines 230 to 232 in 9d17730
installer/pkg/asset/manifests/operators.go
Lines 176 to 177 in ad87acc