openstack: use static .repo file for openstack client #1733
Conversation
openshift-ci-robot
added
size/S
|
This looks fine to me, but we're holding further merges until #1727 lands and unblocks the release. |
|
|
||
| FROM registry.svc.ci.openshift.org/origin/4.1:base | ||
| COPY --from=builder /go/src/github.com/openshift/installer/bin/openshift-install /bin/openshift-install | ||
| COPY --from=builder images/openstack/rdo-stein.repo /etc/yum.repos.d/rdo-stein.repo |
There was a problem hiding this comment.
Hmm, shouldn't we use abs path for this?
There was a problem hiding this comment.
Can we unblock our CI and I will put a follow up to fix this?
|
openstack is non-blocking right? Do we need to fix this, or can we just let the test fail until we get whomever owns it to fix the repo? |
We want to make OpenStack blocking so the OpenStack folks don't keep getting broken by other people's changes ;). Although whether it stays blocking will probably depend on balancing OpenStack test stability vs. our OpenStack support requirements, and I don't have a good handle on either of those. |
|
EDIT: sorry I meant this for another PR
|
|
@cgwalters: cgwalters unauthorized: /override is restricted to repo administrators DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| name=OpenStack Stein Repository | ||
| baseurl=http://mirror.centos.org/centos/7/cloud/$basearch/openstack-stein/ | ||
| #mirrorlist=http://mirrorlist.centos.org/?release=$releasever&arch=$basearch&repo=cloud-openstack-stein | ||
| gpgcheck=0 |
There was a problem hiding this comment.
Wouldn't it be better to keep gpgcheck enabled? The https://www.rdoproject.org/repos/rdo-release.rpm rpm provides the public key for CentOS-SIG-Cloud, we could inject it into the image the same way you do for the repo file.
There was a problem hiding this comment.
sure, I was scrambling to get a patch up quickly yesterday. I didnt think of putting the CentOS-SIG-Cloud public key in a static file like the .repo file.
|
/test e2e-openstack |
|
/lgtm This fixes the e2e-openstack job, we can still fix the 2 nits later |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mandre, trown The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test e2e-aws-upgrade |
How would we ever get to blocking if we just leave our CI in a red state for an unknown period of time? We worked very hard to get a job that provides us visibility into what patches might break us, and currently we have no such visibility. This patch only affects our CI job, and I would appreciate if we can just merge it so our job can go back green. Then I will fix up the inline comments. |
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
9 participants
The openstack repo provided by the release rpm was providing a broken .repo file. Instead, we can use our own static .repo file.