-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Bug 1771564: docs/user/customization: Document additionalTrustBundle vs. proxy #3039
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1771564: docs/user/customization: Document additionalTrustBundle vs. proxy #3039
Conversation
|
@wking: This pull request references Bugzilla bug 1771564, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
looks reasonable to me |
|
I've also filed openshift/api#582 to try to refine the API docs. We should probably hold this PR until that one settles so we can pin to whatever comes after. |
So the relationship is less surprising [1]. The actual semantics of the `trustedCA` type should be defined in the API repository. [1]: https://bugzilla.redhat.com/show_bug.cgi?id=1771564
dc4c100 to
fc4324b
Compare
|
Pushed dc4c10081 -> fc4324b to pin to the API commit after openshift/api#582 landed. |
|
cc @jcpowermac |
|
@wking: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
|
/override ci/prow/e2e-aws-fips |
|
@sdodson: Overrode contexts on behalf of sdodson: ci/prow/e2e-aws-fips, ci/prow/e2e-aws-scaleup-rhel7 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sdodson The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
So the relationship is less surprising. The actual semantics of the
trustedCAtype should be defined in the API repository.