Skip to content

Conversation

@wking
Copy link
Member

@wking wking commented Jan 31, 2020

So the relationship is less surprising. The actual semantics of the trustedCA type should be defined in the API repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jan 31, 2020
@openshift-ci-robot
Copy link
Contributor

@wking: This pull request references Bugzilla bug 1771564, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Bug 1771564: docs/user/customization: Document additionalTrustBundle vs. proxy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 31, 2020
@bparees
Copy link
Contributor

bparees commented Jan 31, 2020

looks reasonable to me

@wking
Copy link
Member Author

wking commented Jan 31, 2020

I've also filed openshift/api#582 to try to refine the API docs. We should probably hold this PR until that one settles so we can pin to whatever comes after.

So the relationship is less surprising [1].  The actual semantics of
the `trustedCA` type should be defined in the API repository.

[1]: https://bugzilla.redhat.com/show_bug.cgi?id=1771564
@wking wking force-pushed the document-addtionalTrustBundle-scope branch from dc4c100 to fc4324b Compare January 31, 2020 22:37
@wking
Copy link
Member Author

wking commented Jan 31, 2020

Pushed dc4c10081 -> fc4324b to pin to the API commit after openshift/api#582 landed.

@patrickdillon
Copy link
Contributor

cc @jcpowermac

@openshift-ci-robot
Copy link
Contributor

@wking: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-fips fc4324b link /test e2e-aws-fips
ci/prow/e2e-aws-scaleup-rhel7 fc4324b link /test e2e-aws-scaleup-rhel7

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sdodson
Copy link
Member

sdodson commented Feb 4, 2020

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 4, 2020
@sdodson
Copy link
Member

sdodson commented Feb 4, 2020

/override ci/prow/e2e-aws-fips
/override ci/prow/e2e-aws-scaleup-rhel7

@openshift-ci-robot
Copy link
Contributor

@sdodson: Overrode contexts on behalf of sdodson: ci/prow/e2e-aws-fips, ci/prow/e2e-aws-scaleup-rhel7

Details

In response to this:

/override ci/prow/e2e-aws-fips
/override ci/prow/e2e-aws-scaleup-rhel7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 4, 2020
@sdodson
Copy link
Member

sdodson commented Feb 4, 2020

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sdodson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. retest-not-required-docs-only size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants