Ensure cluster proxy object sets TrustedCA if only AdditionalTrustBundle is provided

[montaguethomas]

Before this change, the installer would generate an empty spec for the cluster proxy object unless installConfig.Config.Proxy is defined.

This change implements support for the use cases where there is no proxy configured, but there is a desire to include additional trusted CAs.

Related:

• https://access.redhat.com/solutions/6063031
• Case #03038183

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign sdodson after the PR has been reviewed.
You can assign the PR to them by writing /assign @sdodson in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

Hi @montaguethomas. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[wking]

This has been rejected before: #2658, #4082. I recommend looking at rhbz#2009629. I'm going to close this based on the previous two PRs, but I'm not really an installer maintainer anymore, so if any installer maintainers feel like I'm overreaching, feel free to re-open.

[montaguethomas]

I'll pass these resources along to our support case and our TAM. Guess for now we'll just have to keep using our hack:

openshift-install create manifests
[[ -f ./manifests/user-ca-bundle-config.yaml ]] \
  && yq e -P -i '.spec.trustedCA.name = "user-ca-bundle"' ./manifests/cluster-proxy-01-config.yaml
openshift-install create cluster